Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ldc: 1.5.0 -> 1.7.0 #33532

Merged
merged 1 commit into from Jan 10, 2018
Merged

ldc: 1.5.0 -> 1.7.0 #33532

merged 1 commit into from Jan 10, 2018

Conversation

ThomasMader
Copy link
Contributor

Motivation for this change

Update to 1.7.0.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@orivej
Copy link
Contributor

orivej commented Jan 6, 2018

@GrahamcOfBorg build ldc

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: aarch64-linux

Package ‘ldcBuild-1.7.0’ in /var/lib/gc-of-borg/nix-test-rs-3/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-3/pkgs/development/compilers/ldc/default.nix:161 is not supported on ‘aarch64-linux’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: x86_64-darwin

builder for ‘/nix/store/dp475g1wbgbgxa7l3nvpbinwpqs7jx8i-ldc-1.7.0-src.tar.gz.drv’ failed with exit code 254
/nix/store/zsn4rc9p48hsq6a53357fmk314b0ahg4-stdenv-darwin/setup: fork: Operation not permitted
/nix/store/zsn4rc9p48hsq6a53357fmk314b0ahg4-stdenv-darwin/setup: fork: Operation not permitted
builder for ‘/nix/store/2ynb7g7gxc3qi89zvsg9z833z5jdb9k5-ldcBuild-0.17.5.drv’ failed with exit code 254
cannot build derivation ‘/nix/store/x82ggmhbra43cjyc3bc8kn8mgw2005w4-ldcUnittests-0.17.5.drv’: 1 dependencies couldn't be built
cannot build derivation ‘/nix/store/msk5h94yhda2h5khdxdwqvmgd5h87m99-ldc-0.17.5.drv’: 2 dependencies couldn't be built
cannot build derivation ‘/nix/store/5bsj3kz05vnk8ckcjnr3kwza9m8nz201-ldcBuild-1.7.0.drv’: 2 dependencies couldn't be built
cannot build derivation ‘/nix/store/yya6vjxh5w9hn2g0hdg6qbpfkk4amsn8-ldcUnittests-1.7.0.drv’: 3 dependencies couldn't be built
cannot build derivation ‘/nix/store/5c0jzbwaxdybxlhz7k2l4qjsl406w0f4-ldc-1.7.0.drv’: 2 dependencies couldn't be built
error: build of ‘/nix/store/5c0jzbwaxdybxlhz7k2l4qjsl406w0f4-ldc-1.7.0.drv’ failed

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: x86_64-linux

	670 - dmd-testsuite-debug (Failed)
	672 - dmd-testsuite (Failed)
Errors while running CTest
builder for ‘/nix/store/6bv7kndr877r5zpnnm7dz96i5hwjr04d-ldcBuild-0.17.5.drv’ failed with exit code 8
cannot build derivation ‘/nix/store/3a2ic2zbzs9yv64sj5rn6cpfmpgba4rf-ldcUnittests-0.17.5.drv’: 1 dependencies couldn't be built
cannot build derivation ‘/nix/store/kaqvi2c99c623fbpwp0h4cwkg9124dr2-ldc-0.17.5.drv’: 2 dependencies couldn't be built
cannot build derivation ‘/nix/store/z78nv3n12b67w4aq54k74gxjjamkwrhq-ldcBuild-1.7.0.drv’: 1 dependencies couldn't be built
cannot build derivation ‘/nix/store/7jlpmsvg9rqr7ws2fs1mynwa841r3kff-ldcUnittests-1.7.0.drv’: 2 dependencies couldn't be built
cannot build derivation ‘/nix/store/8jzsb5zdb6dd4l7qslr74s5krw1843pb-ldc-1.7.0.drv’: 2 dependencies couldn't be built
error: build of ‘/nix/store/8jzsb5zdb6dd4l7qslr74s5krw1843pb-ldc-1.7.0.drv’ failed

@ThomasMader
Copy link
Contributor Author

  1. The outputs of the bot are not helpful I already searched the last time for the full logs but didn't find them.

  2. On my Mac OS and Fedora machine the build was successful. It also happend yesterday that the build of dmd was not successful for the bot but everywhere else even on hydra as soon as it was merged.
    Why is that?

@joachifm
Copy link
Contributor

joachifm commented Jan 7, 2018

Is it feasible that the test suite is indeterministic somehow? See e.g., #32762 (review) where the build does pass.

Also, I see you indicate that you're not using sandboxing for testing, how do you eliminate the possibility of implicit dependencies & in general ensure reproducibility across systems?

@ThomasMader
Copy link
Contributor Author

Is it feasible that the test suite is indeterministic somehow? See e.g., #32762 (review) where the build does pass.

I don't think so. I built it multiple times on my machines and had no problems.
Usually I build on three machines to test. Fedora, NixOS and Mac OSX
This time I skipped the NixOS build because I was quite sure that it is sufficient to test on Fedora only.
If you look at #33483 (review) you see that the bot build wasn't successful on Darwin too but since it is merged the hydra build was successful. (https://hydra.nixos.org/job/nixpkgs/trunk/dmd.x86_64-darwin)
For me it seems the bot has some issues on Darwin.

Also, I see you indicate that you're not using sandboxing for testing, how do you eliminate the possibility of implicit dependencies & in general ensure reproducibility across systems?

At the moment NixOS is my only system with sandboxing enabled. Normally I would enable it everywhere but needed to disable it on the other systems because of some issues.
AFAIR on Darwin it is currently not supported. Don't remember the issue for Fedora at the moment.

@ThomasMader ThomasMader mentioned this pull request Jan 7, 2018
8 tasks
@ThomasMader
Copy link
Contributor Author

ThomasMader commented Jan 10, 2018

I did the sandbox testing on NixOS now and fixed the problem.
Darwin bot build might not be successful again but since dtools and dmd also had the same problem and building fine on Hydra this is not an issue.

@joachifm joachifm merged commit 3b4ebab into NixOS:master Jan 10, 2018
@ThomasMader ThomasMader deleted the ldc1.7.0 branch January 10, 2018 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants