Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fontconfig: fix postPatch phase for building on GPFS #33511

Closed
wants to merge 1 commit into from

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Jan 6, 2018

The postPatch phase of the fontconfig expression performs patching of
src/fcobjshash.{gperf,h} files and performs "touch" to ensure the make
rule will not get triggered. Editing files in the right order seems to
be a more robust way to do both tasks.

Motivation for this change

This is basically a black magic to fix the build work when $TMP is on a network file system.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

The postPatch phase of the fontconfig expression performs patching of
src/fcobjshash.{gperf,h} files and performs "touch" to ensure the make
rule will not get triggered. Editing files in the right order seems to
be a more robust way to do both tasks.
@veprbl
Copy link
Member Author

veprbl commented Jan 6, 2018

closed in favour of #29704

@veprbl veprbl deleted the fontconfig_fix2 branch December 1, 2020 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants