Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gcc-wrapper-old: grab name of dynamicLinker from bintools #33500

Merged
merged 1 commit into from Jan 6, 2018
Merged

gcc-wrapper-old: grab name of dynamicLinker from bintools #33500

merged 1 commit into from Jan 6, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jan 6, 2018

Motivation for this change

Don't duplicate logic for determining this, bintools exports this information.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@orivej orivej changed the title gcc-wrapper-old: grab name of dynamicLinker for bintools gcc-wrapper-old: grab name of dynamicLinker from bintools Jan 6, 2018
@orivej orivej merged commit 728dda5 into NixOS:master Jan 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @orivej @GrahamcOfBorg