Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jetbrain-editors: 2017.3 -> 2017.3.2 #33536

Merged
merged 1 commit into from Jan 7, 2018
Merged

jetbrain-editors: 2017.3 -> 2017.3.2 #33536

merged 1 commit into from Jan 7, 2018

Conversation

GRBurst
Copy link
Contributor

@GRBurst GRBurst commented Jan 6, 2018

Motivation for change: Updating to latest version.

Motivation for this change

Update to latest version to solve a bug.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@GRBurst GRBurst requested a review from edwtjo as a code owner January 6, 2018 20:13
@andir
Copy link
Member

andir commented Jan 7, 2018

Usually we just execute pkgs/applications/editors/jetbrains/update.pl to update all the jetbrains package. Could you do that instead and update your PR?

@GRBurst
jetbrain-editors: 2017.3 -> 2017.3.2
d578324 
Motivation for change: Updating to latest version.
@GRBurst
Copy link
Contributor Author

GRBurst commented Jan 7, 2018

@andir here you go, thanks for the script hint :-)

@GRBurst GRBurst changed the title idea-community: 2017.3 -> 2017.3.2 jetbrain-editors: 2017.3 -> 2017.3.2 Jan 7, 2018
@joachifm joachifm merged commit 62111e3 into NixOS:master Jan 7, 2018
@GRBurst GRBurst deleted the idea_2017.3.2 branch February 22, 2019 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andir andir andir approved these changes

@edwtjo edwtjo Awaiting requested review from edwtjo edwtjo is a code owner

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@GRBurst @andir @joachifm @GrahamcOfBorg