Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RubyHash to pass #test_create #4947

Merged
merged 3 commits into from
Jan 8, 2018
Merged

Fix RubyHash to pass #test_create #4947

merged 3 commits into from
Jan 8, 2018
+8 −3

Conversation

yui-knk
Copy link
Contributor

@yui-knk yui-knk commented Jan 6, 2018

Warn if wrong type elements are passed to Hash.[]
Ref: https://github.com/ruby/ruby/blob/v2_4_0/hash.c#L693-L696

Raise ArgumentError when invalid number of elements are passed to Hash.[]
Ref: https://github.com/ruby/ruby/blob/v2_4_0/hash.c#L701-L703

@enebo enebo added this to the JRuby 9.2.0.0 milestone Jan 8, 2018
@enebo enebo merged commit 2e8201f into jruby:master Jan 8, 2018
@yui-knk yui-knk deleted the Hash_test_create branch January 8, 2018 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
JRuby 9.2.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yui-knk @enebo