Simplescreenrecorder: 0.3.8 -> 0.3.9 #33497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtojnar
requested changes
Jan 6, 2018
| @@ -24,8 +24,8 @@ stdenv.mkDerivation rec { | |||
| done | |||
There was a problem hiding this comment.
The sed call is no longer necessary MaartenBaert/ssr@853863a
| @@ -24,8 +24,8 @@ stdenv.mkDerivation rec { | |||
| done | |||
| ''; | |||
|
|
|||
| nativeBuildInputs = [ pkgconfig ]; | |||
| buildInputs = [ | |||
| nativeBuildInputs = [ pkgconfig cmake ]; | |||
There was a problem hiding this comment.
Could you also add ninja so that it is used as a builder?
| nativeBuildInputs = [ pkgconfig ]; | ||
| buildInputs = [ | ||
| nativeBuildInputs = [ pkgconfig cmake ]; | ||
| buildInputs = [ | ||
| alsaLib ffmpeg libjack2 libX11 libXext libXfixes mesa | ||
| libpulseaudio qt4 | ||
| ]; |
There was a problem hiding this comment.
enableParallelBuilding = true; no longer needed, cmake builds in parallel by default.
|
@jtojnar thanks for the feedback, done! |
jtojnar
approved these changes
Jan 6, 2018
|
Sweet, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)