Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnome3.nautilus-sendto: fix gettext setup #33519

Closed
wants to merge 1 commit into from
Closed

gnome3.nautilus-sendto: fix gettext setup #33519

wants to merge 1 commit into from

Conversation

srhb
Copy link
Contributor

@srhb srhb commented Jan 6, 2018 •
edited

Motivation for this change

I think this fixes #33458 in accordance with #32626

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@srhb
Copy link
Contributor Author

srhb commented Jan 6, 2018

@jtojnar @orivej I'm not positive that this is the desired fix, but it looked like this has been done elsewhere in order to set it up correctly. Can you comment? Same deal for #33520

@jtojnar
Copy link
Contributor

jtojnar commented Jan 6, 2018

gnome-screenshot does not really need gobjectIntrospection. It works because its setup hook adds $out/share to the environment:

nixpkgs/pkgs/development/libraries/gobject-introspection/setup-hook.sh

Line 9 in 6474e3b

addToSearchPath XDG_DATA_DIRS $1/share

but the more specific gettext setup hook should be fixed instead. envHooks were surpassed by addEnvHooks.

@srhb
Copy link
Contributor Author

srhb commented Jan 6, 2018

@jtojnar I had a feeling. How are these supposed to be used?

@jtojnar
Copy link
Contributor

jtojnar commented Jan 6, 2018 •
edited

I am not sure. There is some documentation in the pull request but I did not have time to study it yet.

@jtojnar jtojnar closed this Jan 6, 2018
@jtojnar
Copy link
Contributor

jtojnar commented Jan 6, 2018

Closed in favour of #33524

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nautilus-sendto 3.8.6 fails to build on NixOS
3 participants
@srhb @jtojnar @GrahamcOfBorg