Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/availableKernelModules: add logitech hid #33529

Merged
merged 1 commit into from Jan 6, 2018

Conversation

jluttine
Copy link
Member

@jluttine jluttine commented Jan 6, 2018

Motivation for this change

This adds support for Logitech (wireless) USB keyboards at boot

See: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1448519

(I wasn't able to boot without this because I wasn't able to enter my LUKS passphrase during boot time and I had no other keyboard available.)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

This adds support for Logitech (wireless) USB keyboards at boot
@orivej orivej force-pushed the add-logitech-usb-kb-kernel-module branch from 05459ba to eeaa82b Compare January 6, 2018 17:14
@orivej orivej merged commit d7d3f35 into NixOS:master Jan 6, 2018
@vcunat
Copy link
Member

vcunat commented Jan 7, 2018

I wonder... backport to 17.09? Ratio of importance vs. risks seems good to me.

vcunat pushed a commit that referenced this pull request Jan 14, 2018
@jluttine
Copy link
Member Author

Actually this doesn't help on current unstable pre18.03. My system just became unbootable.. It worked on 17.09.

@jluttine
Copy link
Member Author

Any ideas why this doesn't help on unstable and how to fix it? I can't boot to my system because I can't enter my LUKS passphraset at boot.

@vcunat
Copy link
Member

vcunat commented Jan 29, 2018

17.09 seems to additionally contain hid_logitech_dj. I have no idea why or what these modules do exactly.

@jluttine
Copy link
Member Author

Oh. I wonder why was it removed.. Maybe should put that back? I'll try if adding it solves my issue.

@jluttine
Copy link
Member Author

I confirm that also adding hid_logitech_dj solves my issue. Could it be added back or why was it dropped?

@vcunat
Copy link
Member

vcunat commented Jan 29, 2018

@fpletz: you removed it in #30172 – perhaps unintentionally? Surprisingly, it was added by myself in #3553 :-)

@fpletz
Copy link
Member

fpletz commented Jan 29, 2018

Oh, according to the commit message it seems to be unintentional indeed. Sorry. :)

@vcunat
Copy link
Member

vcunat commented Feb 3, 2018

Re-added on master.

vcunat added a commit that referenced this pull request Feb 3, 2018
Non-working keyboards during boot are quite a problem; see:
#33529 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants