Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Docs to 7.0.0 #645

Merged
merged 10 commits into from Jan 7, 2018
Merged

Bump Docs to 7.0.0 #645

merged 10 commits into from Jan 7, 2018

Conversation

Inscrutable
Copy link
Member

Also extend copyright to 2018

@Inscrutable
Bump to 7.0.0
f79c084 
Also extend copyright to 2018
@Inscrutable Inscrutable added this to the v7.0.0 milestone Jan 6, 2018
@Inscrutable Inscrutable self-assigned this Jan 6, 2018
@Spongy
Copy link

Spongy commented Jan 6, 2018 •
edited

A preview for this pull request is available at https://cdn.rawgit.com/Spongy/SpongeDocs-PRs/af3730d/.

Here are some links to the pages that were modified:

Since the preview frequently changes, please link to this comment, not to the direct url to the preview.

ST-DDT
ST-DDT approved these changes Jan 6, 2018
View reviewed changes
source/plugin/debugging.rst Outdated
@@ -54,7 +54,7 @@ adding the plugin project to Sponge's classpath will rid you of the necessity to
file into your server directory after every change.

First you need to ensure that you have your Run/Debug Configuration(s) set appropriately, as shown in the Sponge
`README.md <https://github.com/SpongePowered/SpongeForge/blob/stable-6/README.md#Running>`_
`README.md <https://github.com/SpongePowered/SpongeForge/blob/stable-7/README.md#Running>`_
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self: Check whether this needs to be #running.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, the hook needs to be lowercased.

@Inscrutable
Copy link
Member Author

OK, I think that's all we need to at least bump the version to API 7 and let us get started. There will be a lot of files that need tinkering (especially in Plugins). I haven't tweaked the descriptions for the global.conf settings either, a few defaults changed and asynch lighting got threads. Let me know, or add a commit if I missed anything important.

@Inscrutable Inscrutable added the needs review The submission is ready and needs to be reviewed label Jan 6, 2018
ST-DDT
ST-DDT approved these changes Jan 6, 2018
View reviewed changes
Copy link
Member

@ST-DDT ST-DDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Beside the broken hook for the readme, there is only the training whitespace in the config.

@Inscrutable Inscrutable added high priority This needs to be fixed ASAP and removed needs review The submission is ready and needs to be reviewed labels Jan 7, 2018
@Inscrutable Inscrutable merged commit 1971385 into stable Jan 7, 2018
@Inscrutable Inscrutable deleted the Update-to-7.0.0 branch January 26, 2018 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ST-DDT ST-DDT ST-DDT approved these changes

@JBYoshi JBYoshi JBYoshi approved these changes

@parlough parlough parlough approved these changes

Assignees

@Inscrutable Inscrutable

Labels
high priority This needs to be fixed ASAP
Projects
None yet
Milestone
v7.4.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Inscrutable @Spongy @ST-DDT @JBYoshi @parlough