fix few downloads in release-17.09 #33506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This basically backports 9bf3273 ('dns-root-data: use a stable URL that I maintain anyway') /cc NixOS#31862
|
Can you add a note explaining why 9bf3273 is not used instead? It's not clear to me why, anyway. |
|
@joachifm To not have rebuilds caused by change of hash. If this is not important for stable, we can use that of course. |
|
I think for stable the most important thing is to not break/change behavior willy nilly, rebuilds are not an impediment to backporting in general. |
This is a backport of d16b298 ('dns-root-data: use a stable URL that I maintain anyway')
GrahamcOfBorg
added
10.rebuild-darwin: 101-500
10.rebuild-linux: 501+
and removed
10.rebuild-darwin: 0
10.rebuild-linux: 0
labels
|
FWIW the ncurses URL (and other "invisible-island" packages) was improved/fixed in #33340, although I suppose additional mirrors for fixed-hash sources doesn't hurt :). |
FTP URL's should use ftp.invisible-island.net. Signed-off-by: Dmitry Kalinkin <dmitry.kalinkin@gmail.com>
vcunat
approved these changes
Jan 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)