Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wordgrinder: Fix darwin build #33512

Closed
wants to merge 1 commit into from
Closed

wordgrinder: Fix darwin build #33512

wants to merge 1 commit into from

Conversation

adisbladis
Copy link
Member

Motivation for this change

Upstream added official darwin support so I think we should add it too.

I dont actually have a darwin machine to test this on but I think it should work.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

cc @matthiasbeyer

@adisbladis
Copy link
Member Author

@GrahamcOfBorg build wordgrinder

GrahamcOfBorg
GrahamcOfBorg reviewed Jan 6, 2018
View reviewed changes
Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: aarch64-linux

/nix/store/8202504z9g5qp854ba20lyh327sg7m9g-wordgrinder-0.7.1

GrahamcOfBorg
GrahamcOfBorg reviewed Jan 6, 2018
View reviewed changes
Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: x86_64-darwin

140 wrapProgram /nix/store/8w21ij47b807byjgdb2f78zvarsczn2x-hook/nix-support/setup-hook
107 _callImplicitHook /nix/store/zsn4rc9p48hsq6a53357fmk314b0ahg4-stdenv-darwin/setup
124 _eval /nix/store/zsn4rc9p48hsq6a53357fmk314b0ahg4-stdenv-darwin/setup
51 runHook /nix/store/zsn4rc9p48hsq6a53357fmk314b0ahg4-stdenv-darwin/setup
1065 installPhase /nix/store/zsn4rc9p48hsq6a53357fmk314b0ahg4-stdenv-darwin/setup
1239 genericBuild /nix/store/zsn4rc9p48hsq6a53357fmk314b0ahg4-stdenv-darwin/setup
2 main /nix/store/9krlzvny65gdc8s7kpb6lkx8cd02c25b-default-builder.sh

builder for ‘/nix/store/whlxdlp2fzjxckjc8qx7jrdfz75fwlrn-wordgrinder-0.7.1.drv’ failed with exit code 1
error: build of ‘/nix/store/whlxdlp2fzjxckjc8qx7jrdfz75fwlrn-wordgrinder-0.7.1.drv’ failed

GrahamcOfBorg
GrahamcOfBorg reviewed Jan 6, 2018
View reviewed changes
Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-linux

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/j2232nlafxzq205qj1nakd3rzm8kjb1b-wordgrinder-0.7.1
shrinking /nix/store/j2232nlafxzq205qj1nakd3rzm8kjb1b-wordgrinder-0.7.1/bin/.wordgrinder-wrapped
shrinking /nix/store/j2232nlafxzq205qj1nakd3rzm8kjb1b-wordgrinder-0.7.1/bin/.xwordgrinder-wrapped
gzipping man pages under /nix/store/j2232nlafxzq205qj1nakd3rzm8kjb1b-wordgrinder-0.7.1/share/man/
strip is /nix/store/wxn5gn8amxm1w0ikcx4gbs8a17wvss4j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/j2232nlafxzq205qj1nakd3rzm8kjb1b-wordgrinder-0.7.1/bin 
patching script interpreter paths in /nix/store/j2232nlafxzq205qj1nakd3rzm8kjb1b-wordgrinder-0.7.1
checking for references to /tmp/nix-build-wordgrinder-0.7.1.drv-0 in /nix/store/j2232nlafxzq205qj1nakd3rzm8kjb1b-wordgrinder-0.7.1...
/nix/store/j2232nlafxzq205qj1nakd3rzm8kjb1b-wordgrinder-0.7.1

@LnL7 LnL7 added the 6.topic: darwin Running or building packages on Darwin label Jan 6, 2018
@thefloweringash
Copy link
Member

The failure comes from trying to wrap the non-existent xwordgrinder binary:

installing
install flags: install SHELL=/nix/store/hgsbnqhg7zr5vbjazb250ac4wnj3cfhy-bash-4.4-p12/bin/bash PREFIX=\$\(out\) LUA_INCLUDE=/nix/store/wmi94jfnhwg02w9rpp2jkmm5a7rwam8d-lua-5.2.3/include LUA_LIB=/nix/store/wmi94jfnhwg02w9rpp2jkmm5a7rwam8d-lua-5.2.3/lib/liblua.so
[1/3] install -m 644 bin/wordgrinder.1 /nix/store/00a6lcc6hxhvb4xxn73y62iyrd4kj4g5-wordgrinder-0.7.1/share/man/man1/wordgrinder.1
[2/3] install -m 644 README.wg /nix/store/00a6lcc6hxhvb4xxn73y62iyrd4kj4g5-wordgrinder-0.7.1/share/doc/wordgrinder/README.wg
[3/3] install -m 755 bin/wordgrinder-builtin-curses-release-stripped /nix/store/00a6lcc6hxhvb4xxn73y62iyrd4kj4g5-wordgrinder-0.7.1/bin/wordgrinder

Builder called die: Cannot wrap '/nix/store/00a6lcc6hxhvb4xxn73y62iyrd4kj4g5-wordgrinder-0.7.1/bin/xwordgrinder' because it is not an executable file

@adisbladis
Copy link
Member Author

@GrahamcOfBorg build wordgrinder

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Partial log (click to expand)

error: while evaluating the attribute ‘postInstall’ of the derivation ‘wordgrinder-0.7.1’ at /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-zoidberg/pkgs/stdenv/generic/make-derivation.nix:148:11:
value is a string while a list was expected, at /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-zoidberg/pkgs/applications/office/wordgrinder/default.nix:42:17

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Partial log (click to expand)

error: while evaluating the attribute 'postInstall' of the derivation 'wordgrinder-0.7.1' at /var/lib/gc-of-borg/nix-test-rs-1/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-1/pkgs/stdenv/generic/make-derivation.nix:148:11:
value is a string with context while a list was expected, at /var/lib/gc-of-borg/nix-test-rs-1/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-1/pkgs/applications/office/wordgrinder/default.nix:42:17

@adisbladis
Copy link
Member Author

@GrahamcOfBorg build wordgrinder

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

these paths will be fetched (0.14 MiB download, 0.88 MiB unpacked):
  /nix/store/4q9g91cxms75dxh27z3qk610s0v7axab-wordgrinder-0.7.1
  /nix/store/c3yin13j9gq4hc6sgcp84vbg06lghidg-lua5.2-filesystem-1.6.3
copying path '/nix/store/c3yin13j9gq4hc6sgcp84vbg06lghidg-lua5.2-filesystem-1.6.3' from 'https://cache.nixos.org'...
copying path '/nix/store/4q9g91cxms75dxh27z3qk610s0v7axab-wordgrinder-0.7.1' from 'https://cache.nixos.org'...
/nix/store/4q9g91cxms75dxh27z3qk610s0v7axab-wordgrinder-0.7.1

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

these paths will be fetched (0.16 MiB download, 0.93 MiB unpacked):
  /nix/store/37bmg5ljhfwa27nq7iirj3fzfp020yyp-wordgrinder-0.7.1
  /nix/store/4lk634yiwp9hz641wh6c6ynp3rzn8a91-lua5.2-filesystem-1.6.3
copying path '/nix/store/4lk634yiwp9hz641wh6c6ynp3rzn8a91-lua5.2-filesystem-1.6.3' from 'https://cache.nixos.org'...
copying path '/nix/store/37bmg5ljhfwa27nq7iirj3fzfp020yyp-wordgrinder-0.7.1' from 'https://cache.nixos.org'...
/nix/store/37bmg5ljhfwa27nq7iirj3fzfp020yyp-wordgrinder-0.7.1

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Partial log (click to expand)

install flags: install SHELL=/nix/store/s8mff1kmnc63b21ybdid2ni0fw7mzy7r-bash-4.4-p12/bin/bash PREFIX=\$\(out\) LUA_INCLUDE=/nix/store/pdl3va70sl21qf7m1kb5lcgja9cj8b77-lua-5.2.3/include LUA_LIB=/nix/store/pdl3va70sl21qf7m1kb5lcgja9cj8b77-lua-5.2.3/lib/liblua.so
[1/3] install -m 644 bin/wordgrinder.1 /nix/store/apfxviv8jl06qjbrp989bxa0y3v4if9s-wordgrinder-0.7.1/share/man/man1/wordgrinder.1
[2/3] install -m 644 README.wg /nix/store/apfxviv8jl06qjbrp989bxa0y3v4if9s-wordgrinder-0.7.1/share/doc/wordgrinder/README.wg
[3/3] install -m 755 bin/wordgrinder-builtin-curses-release-stripped /nix/store/apfxviv8jl06qjbrp989bxa0y3v4if9s-wordgrinder-0.7.1/bin/wordgrinder
post-installation fixup
gzipping man pages under /nix/store/apfxviv8jl06qjbrp989bxa0y3v4if9s-wordgrinder-0.7.1/share/man/
strip is /nix/store/5a88zk3jgimdmzg8rfhvm93kxib3njf9-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/apfxviv8jl06qjbrp989bxa0y3v4if9s-wordgrinder-0.7.1/bin
patching script interpreter paths in /nix/store/apfxviv8jl06qjbrp989bxa0y3v4if9s-wordgrinder-0.7.1
/nix/store/apfxviv8jl06qjbrp989bxa0y3v4if9s-wordgrinder-0.7.1

@adisbladis
Copy link
Member Author

Pushed in b8f6510

@adisbladis adisbladis closed this Feb 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrahamcOfBorg GrahamcOfBorg GrahamcOfBorg left review comments

@matthiasbeyer matthiasbeyer matthiasbeyer approved these changes

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@adisbladis @thefloweringash @GrahamcOfBorg @matthiasbeyer @LnL7