Do not leak DNS Request IDs #5019
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While jruby@d1a760e fixed handling of compressed IPv6 addresses, it also broke the "freeing" part of it. Currently every DNS request leaks single request id: ``` require 'resolv' Resolv::DNS::RequestID.values.map(&:length) Resolv::DNS.new.getaddress('example.com') Resolv::DNS::RequestID.values.map(&:length) ``` Given the fact that request ids are chosen from `0x0000..0xffff` range - the app can issue 65535 requests and then will be blocked forever trying to allocate another one. This commit makes request id caching work by using same data for allocation and freeing.
|
@olleolleolle @headius I think we will also need to update our MRI stdlib with this commit. I guess though there will be a collection of PRs on this by the time it is done. |
olleolleolle
deleted the
carry-do-not-leak-dns-request-ids-to-jruby-9-1
branch
|
Noting the progress: the above update was done in f8ac719 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This is a cherry-pick of #4981, here against
jruby-9.1.)While d1a760e fixed handling of compressed IPv6 addresses,
it also broke the "freeing" part of it.
Currently every DNS request leaks single request id:
Given the fact that request ids are chosen from
0x0000..0xffffrange - the app can issue 65535 requests and then will be blocked forever trying to allocate another one.This commit makes request id caching work by using same data for allocation and freeing.