Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nano: 2.9.2 -> 2.9.3 #34389

Merged
merged 1 commit into from Jan 29, 2018
Merged

nano: 2.9.2 -> 2.9.3 #34389

merged 1 commit into from Jan 29, 2018

Conversation

lsix
Copy link
Member

@lsix lsix commented Jan 29, 2018

Motivation for this change

See http://lists.gnu.org/archive/html/info-gnu/2018-01/msg00015.html for release announcement

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@FRidh
Copy link
Member

FRidh commented Jan 29, 2018

@GrahamcOfBorg build nano

@FRidh FRidh added the 9.needs: port to stable A PR needs a backport to the stable release. label Jan 29, 2018
Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success on x86_64-linux (full log)

Partial log (click to expand)

shrinking /nix/store/d0nd67mchk5hp0n8yw1m1pvaw1ky728i-nano-2.9.3/bin/nano
gzipping man pages under /nix/store/d0nd67mchk5hp0n8yw1m1pvaw1ky728i-nano-2.9.3/share/man/
strip is /nix/store/mdyy001q67hiks0g24ra53z7ckm4jfr4-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/d0nd67mchk5hp0n8yw1m1pvaw1ky728i-nano-2.9.3/bin 
patching script interpreter paths in /nix/store/d0nd67mchk5hp0n8yw1m1pvaw1ky728i-nano-2.9.3
checking for references to /tmp/nix-build-nano-2.9.3.drv-0 in /nix/store/d0nd67mchk5hp0n8yw1m1pvaw1ky728i-nano-2.9.3...
shrinking RPATHs of ELF executables and libraries in /nix/store/qzy0m62j3mcpghcd0c977j6rncjps8cg-nano-2.9.3-info
strip is /nix/store/mdyy001q67hiks0g24ra53z7ckm4jfr4-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/qzy0m62j3mcpghcd0c977j6rncjps8cg-nano-2.9.3-info
checking for references to /tmp/nix-build-nano-2.9.3.drv-0 in /nix/store/qzy0m62j3mcpghcd0c977j6rncjps8cg-nano-2.9.3-info...

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success on x86_64-darwin (full log)

Partial log (click to expand)

make[2]: Leaving directory '/private/tmp/nix-build-nano-2.9.3.drv-0/nano-2.9.3'
make[1]: Leaving directory '/private/tmp/nix-build-nano-2.9.3.drv-0/nano-2.9.3'
post-installation fixup
gzipping man pages under /nix/store/ym24k36pcamv1khi792ak69j6fyd3idz-nano-2.9.3/share/man/
strip is /nix/store/i1zz228nl3bljcbb83fq0rq7lr7nvv4y-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/ym24k36pcamv1khi792ak69j6fyd3idz-nano-2.9.3/bin
patching script interpreter paths in /nix/store/ym24k36pcamv1khi792ak69j6fyd3idz-nano-2.9.3
strip is /nix/store/i1zz228nl3bljcbb83fq0rq7lr7nvv4y-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/8cmgx23gk8w359ivzl113f0qkv1rzbal-nano-2.9.3-info
/nix/store/ym24k36pcamv1khi792ak69j6fyd3idz-nano-2.9.3

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success on aarch64-linux (full log)

Partial log (click to expand)

shrinking /nix/store/mhpcb468iadpqiaz5zj6m4cjxjn31xwd-nano-2.9.3/bin/nano
gzipping man pages under /nix/store/mhpcb468iadpqiaz5zj6m4cjxjn31xwd-nano-2.9.3/share/man/
strip is /nix/store/jwz859pxqj7sl2dbwvmxkx68jp774izb-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/mhpcb468iadpqiaz5zj6m4cjxjn31xwd-nano-2.9.3/bin
patching script interpreter paths in /nix/store/mhpcb468iadpqiaz5zj6m4cjxjn31xwd-nano-2.9.3
checking for references to /build in /nix/store/mhpcb468iadpqiaz5zj6m4cjxjn31xwd-nano-2.9.3...
shrinking RPATHs of ELF executables and libraries in /nix/store/wpdr92159n8hv9k355w9lnyxqvzia2b0-nano-2.9.3-info
strip is /nix/store/jwz859pxqj7sl2dbwvmxkx68jp774izb-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/wpdr92159n8hv9k355w9lnyxqvzia2b0-nano-2.9.3-info
checking for references to /build in /nix/store/wpdr92159n8hv9k355w9lnyxqvzia2b0-nano-2.9.3-info...

@FRidh FRidh merged commit 1941219 into NixOS:master Jan 29, 2018
@FRidh
Copy link
Member

FRidh commented Jan 29, 2018

@lsix can you backport this fix?

@lsix
Copy link
Member Author

lsix commented Jan 30, 2018

@FRidh release-17.09 uses nano-2.8.7 (last of the 2.8 branch). Backporting this wold get stable to move from 2.8 to 2.9, is this what we want?

@FRidh
Copy link
Member

FRidh commented Jan 30, 2018

@lsix ah, I wasn't aware stable is on 2.8. Nevermind.

@samueldr samueldr removed the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 17, 2019
@lsix lsix deleted the nano_2_9_3 branch August 22, 2019 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants