Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 577d13a46bb0
Choose a base ref
...
head repository: jruby/jruby
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 323169c399b9
Choose a head ref
  • 2 commits
  • 1 file changed
  • 2 contributors

Commits on Jan 27, 2018

  1. Exclude #test_windows_1255 from our tests 

    We use jcodings 1.0.27 which maps
windows-1255 0xCA to UTF-8 U+05BA.
But this had been supported since CRuby 2.4.

Ref: ruby/ruby@b24e093
    @yui-knk
    yui-knk committed Jan 27, 2018

    Unverified

    The committer email address is not verified.
    Learn about vigilant mode
    Copy the full SHA
    b337ce0 View commit details

Commits on Jan 29, 2018

  1. Merge pull request #5016 from yui-knk/test_windows_1255 

    Exclude `#test_windows_1255` from our tests
    @enebo
    enebo authored Jan 29, 2018

    Unverified

    The committer email address is not verified.
    Learn about vigilant mode
    Copy the full SHA
    323169c View commit details
Showing with 1 addition and 0 deletions.
  1. +1 −0 test/mri/excludes/TestTranscode.rb
1 change: 1 addition & 0 deletions test/mri/excludes/TestTranscode.rb
View file
Original file line number Diff line number Diff line change
@@ -2,3 +2,4 @@
exclude :test_to_cp50221, "needs investigation"
exclude :test_unicode_public_review_issue_121, "broken via charset replacement"
exclude :test_utf8_mac, "needs investigation"
exclude :test_windows_1255, "jcodings 1.0.27 maps windows-1255 0xCA to UTF-8 U+05BA which was not supported in CRuby 2.3."