keepass: change from mono40 to mono54 #34398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue NixOS#31859 (NixOS#31859) highlighted TLSv1.1 / TLSv1.2 support isn't available with older versions of Mono 4. This change moves to use Mono 5.4. Tested as working with Keepass v2.38 for which PR NixOS#34360 is already open.
8 tasks
|
@fpletz @copumpkin this PR is with Does it meet with your approval now it's against the latest Thanks for your advice so far. |
|
@GrahamcOfBorg build keepass |
There was a problem hiding this comment.
Failure on aarch64-linux (full log)
Partial log (click to expand)
Package ‘mono-4.0.4.1’ in /var/lib/gc-of-borg/nix-test-rs-1/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-1/pkgs/development/compilers/mono/generic.nix:90 is not supported on ‘aarch64-linux’, refusing to evaluate.
a) For `nixos-rebuild` you can set
{ nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.
b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
{ allowBroken = true; }
to ~/.config/nixpkgs/config.nix.
There was a problem hiding this comment.
Success on x86_64-linux (full log)
Partial log (click to expand)
/nix/store/5ign2lkldb3ifx84jwl7ilgm5wzinq6m-keepass-2.37 /tmp/nix-build-keepass-2.37.drv-0
/tmp/nix-build-keepass-2.37.drv-0
Created /nix/store/5ign2lkldb3ifx84jwl7ilgm5wzinq6m-keepass-2.37/lib/pkgconfig/KeePassLib.pc
rscFileExt=ico
glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/5ign2lkldb3ifx84jwl7ilgm5wzinq6m-keepass-2.37
patching script interpreter paths in /nix/store/5ign2lkldb3ifx84jwl7ilgm5wzinq6m-keepass-2.37
checking for references to /tmp/nix-build-keepass-2.37.drv-0 in /nix/store/5ign2lkldb3ifx84jwl7ilgm5wzinq6m-keepass-2.37...
/nix/store/5ign2lkldb3ifx84jwl7ilgm5wzinq6m-keepass-2.37
There was a problem hiding this comment.
Success on x86_64-darwin (full log)
Partial log (click to expand)
'Build/KeePassLib/Release/KeePassLib.pdb' -> '/nix/store/kq7xf6zf3lws5yashf3kjff9jl1c0bzz-keepass-2.37/lib/dotnet/keepass/KeePassLib.pdb'
'Build/KeePassLib/Release/KeePassLib.xml' -> '/nix/store/kq7xf6zf3lws5yashf3kjff9jl1c0bzz-keepass-2.37/lib/dotnet/keepass/KeePassLib.xml'
/nix/store/kq7xf6zf3lws5yashf3kjff9jl1c0bzz-keepass-2.37 /private/tmp/nix-build-keepass-2.37.drv-0
/private/tmp/nix-build-keepass-2.37.drv-0
Created /nix/store/kq7xf6zf3lws5yashf3kjff9jl1c0bzz-keepass-2.37/lib/pkgconfig/KeePassLib.pc
rscFileExt=ico
glibPreFixupPhase
post-installation fixup
patching script interpreter paths in /nix/store/kq7xf6zf3lws5yashf3kjff9jl1c0bzz-keepass-2.37
/nix/store/kq7xf6zf3lws5yashf3kjff9jl1c0bzz-keepass-2.37
|
Looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #31859 highlighted TLSv1.1 / TLSv1.2 support isn't available with older versions of Mono 4. This change moves to use Mono 5.4. Tested as working with Keepass v2.38 for which PR #34360 is already open.
Motivation for this change
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)