Fix macOS installation when umask disallow public read (solves #1582) #1825
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1582 happens when the user running the install has an umask that disallows public read (eg:
umask 0027
)./nix/store
is created withmkdir -pv -m 1775 /nix/store
, but thenrsync -rlpt "$(pwd)/store/" "$NIX_ROOT/store/"
syncs the permissions on/nix/store
to those of$(pwd)/store/
.Replacing
rsync -rlpt "$(pwd)/store/" "$NIX_ROOT/store/"
withrsync -rlpt ./store/* "$NIX_ROOT/store/"
solves the issue by syncing the contents of./store
instead of the folder itself (of course.
is the same as$(pwd)
, just clearer imho).