Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

awstats: add tools directory #34397

Merged
merged 1 commit into from Feb 2, 2018
Merged

awstats: add tools directory #34397

merged 1 commit into from Feb 2, 2018

Conversation

griff
Copy link
Contributor

@griff griff commented Jan 29, 2018 •
edited

Motivation for this change

awstats has a tools directory with command line helper tools but it was not included in the derivation output. This change simply adds the tools directory to the output.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Jan 30, 2018

Are these tools already usable in its current form? Do people find them there?

@Mic92
Copy link
Member

Mic92 commented Jan 30, 2018 •
edited

I would put them in $out/share/awstats so they will end up in /run/current-system/sw/share/awstats on the system, when installed.

@griff
Copy link
Contributor Author

griff commented Feb 1, 2018

@Mic92 you raised a good point so I looked at where CentOS and Debian store the tools and the consensus there is to store the tools in /usr/share/awstats/tools and the documentation for awstats talks about the tools directory so I have changed the commit to store tools in $out/share/awstats/tools.

@Mic92 Mic92 merged commit 9a5fe79 into NixOS:master Feb 2, 2018
@griff griff mentioned this pull request Feb 4, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@griff @Mic92 @GrahamcOfBorg