keybase: 1.0.39 -> 1.0.40 #34395
Merged
keybase: 1.0.39 -> 1.0.40 #34395
+7
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nitpick: please use separate commits for each bump, per policy |
|
@GrahamcOfBorg build keybase keybase-gui kbfs |
There was a problem hiding this comment.
Failure on x86_64-darwin (full log)
Partial log (click to expand)
Package ‘keybase-gui-1.0.40-20180127033950.76a4b90c9’ in /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/tools/security/keybase-gui/default.nix:88 is not supported on ‘x86_64-darwin’, refusing to evaluate.
a) For `nixos-rebuild` you can set
{ nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.
b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
{ allowBroken = true; }
to ~/.config/nixpkgs/config.nix.
There was a problem hiding this comment.
Success on x86_64-linux (full log)
Partial log (click to expand)
/nix/store/zxb5rcppdnibgsmqjwbpqlh40w5xdhi7-keybase-1.0.40/share/go/src/github.com/keybase/client/packaging/github/kbfs.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/i0ay05pqkbnvpfijm52mmlrp6kmkl80c-bash-4.4-p12/bin/bash"
/nix/store/zxb5rcppdnibgsmqjwbpqlh40w5xdhi7-keybase-1.0.40/share/go/src/github.com/keybase/client/packaging/github/keybase.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/i0ay05pqkbnvpfijm52mmlrp6kmkl80c-bash-4.4-p12/bin/bash"
/nix/store/zxb5rcppdnibgsmqjwbpqlh40w5xdhi7-keybase-1.0.40/share/go/src/github.com/keybase/client/packaging/check_status_and_pull.sh: interpreter directive changed from " /usr/bin/env bash" to "/nix/store/i0ay05pqkbnvpfijm52mmlrp6kmkl80c-bash-4.4-p12/bin/bash"
/nix/store/zxb5rcppdnibgsmqjwbpqlh40w5xdhi7-keybase-1.0.40/share/go/src/github.com/keybase/client/packaging/ios/build_and_publish.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/i0ay05pqkbnvpfijm52mmlrp6kmkl80c-bash-4.4-p12/bin/bash"
/nix/store/zxb5rcppdnibgsmqjwbpqlh40w5xdhi7-keybase-1.0.40/share/go/src/github.com/keybase/client/packaging/slack/send.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/i0ay05pqkbnvpfijm52mmlrp6kmkl80c-bash-4.4-p12/bin/bash"
/nix/store/zxb5rcppdnibgsmqjwbpqlh40w5xdhi7-keybase-1.0.40/share/go/src/github.com/keybase/client/packaging/brew/brew.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/i0ay05pqkbnvpfijm52mmlrp6kmkl80c-bash-4.4-p12/bin/bash"
checking for references to /tmp/nix-build-keybase-1.0.40.drv-0 in /nix/store/zxb5rcppdnibgsmqjwbpqlh40w5xdhi7-keybase-1.0.40...
/nix/store/c4q38vbbaqvr9xgf4dkkb0rkkcry656v-keybase-1.0.40-bin
/nix/store/hsn2bvxif1yw0rx7b0h1qn6m89ajcknf-keybase-gui-1.0.40-20180127033950.76a4b90c9
/nix/store/5c0p3qkpw9wrifmj6crp611h80hidrjj-kbfs-1.0.40-bin
There was a problem hiding this comment.
Success on aarch64-linux (full log)
Partial log (click to expand)
/nix/store/jh5vrchavz23nmyywmf5pgfyvjixm3r2-keybase-1.0.40/share/go/src/github.com/keybase/client/osx/Fuse/uninstall.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/rc78viijga8i0m4imrnqk8d1csyqr8yx-bash-4.4-p12/bin/bash"
/nix/store/jh5vrchavz23nmyywmf5pgfyvjixm3r2-keybase-1.0.40/share/go/src/github.com/keybase/client/osx/Helper/uninstall_helper.sh: interpreter directive changed from "/bin/sh" to "/nix/store/rc78viijga8i0m4imrnqk8d1csyqr8yx-bash-4.4-p12/bin/sh"
/nix/store/jh5vrchavz23nmyywmf5pgfyvjixm3r2-keybase-1.0.40/share/go/src/github.com/keybase/client/osx/Scripts/build.sh: interpreter directive changed from "/bin/bash" to "/nix/store/rc78viijga8i0m4imrnqk8d1csyqr8yx-bash-4.4-p12/bin/bash"
/nix/store/jh5vrchavz23nmyywmf5pgfyvjixm3r2-keybase-1.0.40/share/go/src/github.com/keybase/client/osx/Scripts/build_installer.sh: interpreter directive changed from "/bin/bash" to "/nix/store/rc78viijga8i0m4imrnqk8d1csyqr8yx-bash-4.4-p12/bin/bash"
/nix/store/jh5vrchavz23nmyywmf5pgfyvjixm3r2-keybase-1.0.40/share/go/src/github.com/keybase/client/osx/Scripts/build_status.sh: interpreter directive changed from "/bin/bash" to "/nix/store/rc78viijga8i0m4imrnqk8d1csyqr8yx-bash-4.4-p12/bin/bash"
/nix/store/jh5vrchavz23nmyywmf5pgfyvjixm3r2-keybase-1.0.40/share/go/src/github.com/keybase/client/osx/Scripts/versions.sh: interpreter directive changed from "/bin/sh" to "/nix/store/rc78viijga8i0m4imrnqk8d1csyqr8yx-bash-4.4-p12/bin/sh"
checking for references to /build in /nix/store/jh5vrchavz23nmyywmf5pgfyvjixm3r2-keybase-1.0.40...
/nix/store/is5sx1k334rcrwj2m50isnn35rsbp6mf-keybase-1.0.40-bin
/nix/store/81kgks071qhpllmmjll20bfilkji2ma9-keybase-gui-1.0.40-20180127033950.76a4b90c9
/nix/store/a7w6hxnrypm9nmmnby2ira7d99cv51yl-kbfs-1.0.40-bin
jonafato
force-pushed
the
keybase-1.0.40
branch
from
20fff57 to
4662593
Compare
|
@joachifm Updated with a commit for each package. I initially did all three as one commit because of the nature of the issue (runtime errors due to the version mismatch). What's considered best practice for packages that should be updated together like this? |
|
A low-tech solution is to rely on the merge object to encode that the commits belong together. |
|
@joachifm Any other change requests here? If they need to be split up into separate pull requests, let me know. |
|
Nothing further from me; keeping them in the same PR makes sense, for the reasons you've enumerated above. |
jonafato
force-pushed
the
keybase-1.0.40
branch
from
4662593 to
7e714bd
Compare
|
Bump. |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
There is a new keybase release available.
Additionally, update
keybase-guiandkbfsto 1.0.40. This isnecessary to prevent errors in
keybase-guiwhen versions aremismatched.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)