acme-client: init at 0.1.6 #33996
Merged
acme-client: init at 0.1.6 #33996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukateras
reviewed
Jan 18, 2018
|
|
||
| src = fetchurl { | ||
| url = "https://kristaps.bsd.lv/acme-client/snapshots/acme-client-portable-${version}.tgz"; | ||
| sha512 = "730c20bdf9d72b24e66c54b009a282e04da3ea8ce3b9eb053750672c53c9586b2879d87a565ddbab033d7ba6a577dd6399313b20cf654b185905db4de988b6b7"; |
There was a problem hiding this comment.
Nix format (Base32) is preferred. Also, sha256 should be sufficient.
There was a problem hiding this comment.
Grabbed it from upstream's download page; will change
|
|
||
| meta = { | ||
| homepage = https://kristaps.bsd.lv/acme-client/; | ||
| description = "Secure acme/Let's Encrypt client"; |
There was a problem hiding this comment.
This is copied verbatim from upstream's description, but happy to change.
| meta = { | ||
| homepage = https://kristaps.bsd.lv/acme-client/; | ||
| description = "Secure acme/Let's Encrypt client"; | ||
| platforms = stdenv.lib.platforms.all; |
There was a problem hiding this comment.
If meta had with stdenv.lib, it could have been omitted on individual attributes:
meta = with stdenv.lib; {
platforms = platforms.all;
license = licenses.isc;
}
Also, it seems unlikely to me that it would run on Windows: probably you've meant platforms.unix.
There was a problem hiding this comment.
Great review, appreciate the careful look! Will make all those changes.
| @@ -0,0 +1,36 @@ | |||
| { stdenv | |||
| , apple_sdk | |||
There was a problem hiding this comment.
Given that this attribute is only required on Darwin, it could be optional:
, apple_sdk ? null
|
@yegortimoshenko your comments have been addressed, thanks! |
|
@GrahamcOfBorg build acme-client |
|
Success on x86_64-linux (full log) Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Partial log (click to expand)
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Add acme-client package.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)