Makefile: Colors work now! #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make qemu script work on Arch
If TFTP_SERVER_PORT is set in the environment, TFTP server will be started on that port; if not, it is started on UDP/69 (well known TFTP service port) as before. If TFTP_SERVER_PORT is set in environment during build of litex BIOS, then TFTP client will try to reach TFTP server on that port first before falling back to UDP/69. If TFTP_SERVER_PORT >= 1024 then TFTP server is started as user without using sudo (otherwise sudo is used as before). Tested with atftpd; in.tftpd equivalent added but not tested.
|
Err....log files now contain the color sequences |
|
@rohitk-singh Is that a problem? |
|
@mithro Not really. Just a compromise for much better build output |
|
You can view the logs with |
Less root is good...
|
@mithro Wow, nice! |
This also removes the "sudo which atftpd" command to avoid running sudo just to find out where TFTP server is; instead we try "which atftpd" (as user, not root), and then fall back to /usr/sbin/atftpd
TFTP: Support alternate TFTP Server Port
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.