MBS-9608: Update URL cleanup to handle new Bandsintown’s URL format #604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bandsintown recently changed its default URL pattern: It uses one-letter prefix (instead of no prefix for artist and type name for event and venue) and numeric ID everywhere (instead of artist name). Bandinstown correctly redirect URLs using the old format, but MusicBrainz does not accept entering URLs in the new format yet. This patch updates Bandsintown URL cleanup to handle both URL formats from user input, to convert input URLs in old format to the new format, and to validate URLs in the new format only.
yvanzo
changed the title
yvanzo
force-pushed
the
mbs-9608-bandsintown-venues
branch
from
ea8a355
to
0a1e6dd
Compare
Bandsintown redesigned its website and changed its default domain name. Although redirects work (more or less according to MBS-9559), newly entered URLs should not artificially require it. This patch normalize newly entered/edited Bandsintwon URLs to the new default `www.bandsintown.com` instead of `bandsintown.com`.
It also prevents any potential further resurgence of MBS-9559.
Input relationship type substitutes to expected relationship type to test only valid entity types with user-selected relationship type.
|
Failing |
|
@brainzbot, retest this please. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MBS-9608: Update Bandsintown URL cleanup to the new format
Bandsintown recently changed its default URL pattern: It uses one-letter prefix (instead of no prefix for artist and type name for
eventandvenue) and numeric ID everywhere (instead of artist name).While Bandinstown correctly redirect URLs using the old format, MusicBrainz doesn’t accept entering URLs in the new format yet.
This patch updates Bandsintown URL cleanup to handle both URL formats from user input, to convert input URLs in old format to the new format, and to validate URLs in the new format only.
Additionally, it normalizes Bandsintown URLs to use the new default subdomain
ẁwwofbandsintown.com. It should prevent potential further reopening of MBS-9559.