Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buildbot: 0.9.11 -> 0.9.15.post1 #33992

Merged
merged 2 commits into from Feb 3, 2018
Merged

buildbot: 0.9.11 -> 0.9.15.post1 #33992

merged 2 commits into from Feb 3, 2018

Conversation

lopsided98
Copy link
Contributor

Motivation for this change

Updates buildbot to 0.9.15.post1.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@FRidh
Copy link
Member

FRidh commented Jan 18, 2018

cc maintainers @nand0p @ryansydnor

@adisbladis
Copy link
Member

@GrahamcOfBorg build buildbot

GrahamcOfBorg
GrahamcOfBorg reviewed Jan 23, 2018
View reviewed changes
Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: x86_64-linux

buildbot.test.unit.test_version.VersioningUtilsTests_PKG.test_gitDescribeToPep440devVersion
buildbot.test.unit.test_version.VersioningUtilsTests_PKG.test_gitDescribeToPep440p1dev
buildbot.test.unit.test_version.VersioningUtilsTests_PKG.test_gitDescribeToPep440p1tag
buildbot.test.unit.test_version.VersioningUtilsTests_PKG.test_gitDescribeToPep440tag
-------------------------------------------------------------------------------
Ran 5231 tests in 122.976s

FAILED (skips=236, errors=6, successes=4989)
builder for ‘/nix/store/0mikqyim45q2j6agj484xvsas52ddr6z-buildbot-0.9.15.post1.drv’ failed with exit code 1
error: build of ‘/nix/store/0mikqyim45q2j6agj484xvsas52ddr6z-buildbot-0.9.15.post1.drv’ failed

GrahamcOfBorg
GrahamcOfBorg reviewed Jan 23, 2018
View reviewed changes
Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: aarch64-linux

buildbot.test.unit.test_version.VersioningUtilsTests_PKG.test_gitDescribeToPep440devVersion
buildbot.test.unit.test_version.VersioningUtilsTests_PKG.test_gitDescribeToPep440p1dev
buildbot.test.unit.test_version.VersioningUtilsTests_PKG.test_gitDescribeToPep440p1tag
buildbot.test.unit.test_version.VersioningUtilsTests_PKG.test_gitDescribeToPep440tag
-------------------------------------------------------------------------------
Ran 5231 tests in 379.563s

FAILED (skips=236, errors=15, successes=4986)
builder for '/nix/store/na67ynjz6fc4b5wprl6xpyfgpmlsjq8k-buildbot-0.9.15.post1.drv' failed with exit code 1
error: build of '/nix/store/na67ynjz6fc4b5wprl6xpyfgpmlsjq8k-buildbot-0.9.15.post1.drv' failed

GrahamcOfBorg
GrahamcOfBorg reviewed Jan 23, 2018
View reviewed changes
Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: x86_64-darwin

buildbot.test.unit.test_version.VersioningUtilsTests_PKG.test_gitDescribeToPep440devVersion
buildbot.test.unit.test_version.VersioningUtilsTests_PKG.test_gitDescribeToPep440p1dev
buildbot.test.unit.test_version.VersioningUtilsTests_PKG.test_gitDescribeToPep440p1tag
buildbot.test.unit.test_version.VersioningUtilsTests_PKG.test_gitDescribeToPep440tag
-------------------------------------------------------------------------------
Ran 5231 tests in 193.527s

FAILED (skips=237, errors=6, successes=4988)
builder for '/nix/store/7qx9vw02wnrf6kpmayrq4xizlns5wfaf-buildbot-0.9.15.post1.drv' failed with exit code 1
error: build of '/nix/store/7qx9vw02wnrf6kpmayrq4xizlns5wfaf-buildbot-0.9.15.post1.drv' failed

@lopsided98
Copy link
Contributor Author

Oops, it looks like one of my overlays disabled the tests, so I didn't see these failures. I'm really busy this week, so I'll look into this over the weekend.

@lopsided98
Copy link
Contributor Author

The problem seems to be that buildbot runs tests that require buildbot-pkg to be available. buildbot-pkg is currently only used by the plugins, and is not a real package (the derivation is defined in a let block in plugins.nix).

I moved buildbot-pkg to its own file and added it as a buildInput of buildbot. This fixed the tests, but introduced a new problem, seemingly related to how buildbot_pkg monkey patches os.listdir

This is the current error, which I can't find a way to fix:

Traceback (most recent call last):
  File "nix_run_setup", line 8, in <module>
    exec(compile(getattr(tokenize, 'open', open)(__file__).read().replace('\\r\\n', '\\n'), __file__, 'exec'))
  File "setup.py", line 556, in <module>
    setup(**setup_args)
  File "/nix/store/a4zb290zkx8avpand4a58ndci8ppczik-python2.7-bootstrapped-pip-9.0.1/lib/python2.7/site-packages/setuptools/__init__.py", line 129, in setup
    return distutils.core.setup(**attrs)
  File "/nix/store/87l8l9w3x8saxqz9sfcfw2i3jiilmxfi-python-2.7.14/lib/python2.7/distutils/core.py", line 151, in setup
    dist.run_commands()
  File "/nix/store/87l8l9w3x8saxqz9sfcfw2i3jiilmxfi-python-2.7.14/lib/python2.7/distutils/dist.py", line 953, in run_commands
    self.run_command(cmd)
  File "/nix/store/87l8l9w3x8saxqz9sfcfw2i3jiilmxfi-python-2.7.14/lib/python2.7/distutils/dist.py", line 972, in run_command
    cmd_obj.run()
  File "/nix/store/a4zb290zkx8avpand4a58ndci8ppczik-python2.7-bootstrapped-pip-9.0.1/lib/python2.7/site-packages/setuptools/command/test.py", line 226, in run
    self.run_tests()
  File "/nix/store/87l8l9w3x8saxqz9sfcfw2i3jiilmxfi-python-2.7.14/lib/python2.7/contextlib.py", line 35, in __exit__
    self.gen.throw(type, value, traceback)
  File "/nix/store/a4zb290zkx8avpand4a58ndci8ppczik-python2.7-bootstrapped-pip-9.0.1/lib/python2.7/site-packages/setuptools/command/test.py", line 171, in project_on_sys_path
    working_set.__init__()
  File "/nix/store/a4zb290zkx8avpand4a58ndci8ppczik-python2.7-bootstrapped-pip-9.0.1/lib/python2.7/site-packages/pkg_resources/__init__.py", line 650, in __init__
    self.add_entry(entry)
  File "/nix/store/a4zb290zkx8avpand4a58ndci8ppczik-python2.7-bootstrapped-pip-9.0.1/lib/python2.7/site-packages/pkg_resources/__init__.py", line 706, in add_entry
    for dist in find_distributions(entry, True):
  File "/nix/store/a4zb290zkx8avpand4a58ndci8ppczik-python2.7-bootstrapped-pip-9.0.1/lib/python2.7/site-packages/pkg_resources/__init__.py", line 2032, in find_on_path
    entries = safe_listdir(path_item)
  File "/nix/store/a4zb290zkx8avpand4a58ndci8ppczik-python2.7-bootstrapped-pip-9.0.1/lib/python2.7/site-packages/pkg_resources/__init__.py", line 2091, in safe_listdir
    return os.listdir(path)
  File "/nix/store/8gkpajpp6fl78ck3jjdy3znnpswqakm4-python2.7-buildbot-pkg-0.9.15.post1/lib/python2.7/site-packages/buildbot_pkg.py", line 41, in listdir
    l = old_listdir(path)
TypeError: 'NoneType' object is not callable

@FRidh FRidh merged commit 2564ea9 into NixOS:master Feb 3, 2018
@FRidh
Copy link
Member

FRidh commented Feb 3, 2018

@lopsided98 fixed with 73d985f

FRidh added a commit that referenced this pull request Feb 3, 2018
@FRidh
buildbot: buildbot-pkg fix
73d985f 
Fixes issue mentioned in
#33992 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrahamcOfBorg GrahamcOfBorg GrahamcOfBorg left review comments

@FRidh FRidh FRidh approved these changes

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lopsided98 @FRidh @adisbladis @GrahamcOfBorg