Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

freetype: 2.7.1 -> 2.9 #33995

Closed
wants to merge 1 commit into from
Closed

freetype: 2.7.1 -> 2.9 #33995

wants to merge 1 commit into from

Conversation

mogorman
Copy link
Contributor

@mogorman mogorman commented Jan 18, 2018 •
edited

Motivation for this change

Version bump from 2.7.1 to 2.9, also allows us to get rid of some of these patches that have now been rolled into the repo directly.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@adisbladis
Copy link
Member

adisbladis commented Jan 18, 2018 •
edited

Thanks for your PR!

Considering the amount of rebuilds could you rebase this on staging?

Estimating rebuild amount by counting changed Hydra jobs.
   1150 x86_64-darwin
   4310 x86_64-linux

@mogorman mogorman changed the base branch from master to staging January 18, 2018 14:51
@mogorman
Copy link
Contributor Author

@adisbladis changed to staging

@jtojnar
Copy link
Contributor

jtojnar commented Jan 19, 2018

See also #29704

@ttuegel ttuegel self-requested a review February 26, 2018 13:36
@jtojnar jtojnar mentioned this pull request Mar 6, 2018
Merged
8 tasks
@abbradar
Copy link
Member

Closed by #36371

@abbradar abbradar closed this Mar 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel Awaiting requested review from ttuegel

Assignees
No one assigned
Labels
1.severity: mass-rebuild 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mogorman @adisbladis @jtojnar @abbradar @GrahamcOfBorg