Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

json-glib: fixup darwin install_name #34431

Merged
merged 1 commit into from Feb 1, 2018
Merged

json-glib: fixup darwin install_name #34431

merged 1 commit into from Feb 1, 2018

Conversation

LnL7
Copy link
Member

@LnL7 LnL7 commented Jan 30, 2018

Motivation for this change

Couldn't figure out how to fix it durning the build.

Fixes the rpath issues in #34428

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@LnL7
json-glib: fixup darwin install_name
787d371 
Couldn't figure out how to fix it durning the build.
@LnL7 LnL7 requested a review from jtojnar January 30, 2018 21:06
@vbgl
Copy link
Contributor

vbgl commented Jan 30, 2018

A similar patch would fix mpd_clientlib. That package is also built using meson and ninja. Maybe patching this build system would fix many packages at once.

@LnL7
Copy link
Member Author

LnL7 commented Jan 30, 2018

I agree, but didn't want to go down that rabbit-hole right now. I also don't really know anything about meson.

@LnL7 LnL7 added the 6.topic: darwin Running or building packages on Darwin label Jan 30, 2018
@jtojnar jtojnar mentioned this pull request Feb 1, 2018
Merged
8 tasks
@LnL7 LnL7 merged commit a64f8e8 into NixOS:master Feb 1, 2018
@LnL7 LnL7 deleted the darwin-json-glib branch February 1, 2018 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar approved these changes

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 101-500 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@LnL7 @vbgl @jtojnar @GrahamcOfBorg