Skip to content

Commit

Permalink
wineUnstable: 2.21 -> 3.0
Browse files Browse the repository at this point in the history
wineStaging redirects to wineUnstable, for now
  • Loading branch information
bendlas committed Jan 25, 2018
1 parent 7a26625 commit 4fec62d
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 7 deletions.
9 changes: 5 additions & 4 deletions pkgs/misc/emulators/wine/default.nix
Expand Up @@ -56,9 +56,10 @@ let wine-build = build: release:
});

in if wineRelease == "staging" then
callPackage ./staging.nix {
inherit libtxc_dxtn_Name;
wineUnstable = wine-build wineBuild "unstable";
}
let wineUnstable = wine-build wineBuild "unstable"; in
builtins.trace "WARNING: wine staging is not yet at 3.0, using unstable" ( wineUnstable )

This comment has been minimized.

Copy link
@peti

peti Jan 26, 2018

Member

@bendlas, that trace message is a bad idea. Please remove that message again. The unexpected output is very confusing and it's somewhat likely to break scripts that interpret nix-env output in some way (as it happened to me).

This comment has been minimized.

Copy link
@bendlas

bendlas Jan 26, 2018

Author Contributor

Since we already are at the point of strong wordings: The actual bad Idea here is to have a script interpret stderr.
Also, if you're seeign that message, it means that you're installing wine with staging patches: An experimental technology. You should be able to deal with warnings, when handling experimental technology.
That said, I'll do away with the warning, when coming home this evening, to avoid any further confusion ...

This comment has been minimized.

Copy link
@peti

peti Jan 26, 2018

Member

The actual bad Idea here is to have a script interpret stderr.

Whatever. This is irrelevant to my point. Nixpkgs should not print out random warnings that users don't know how to interpret.

if you're seeign that message, it means that you're installing wine with staging patches

No, I am not:

$ nix-env -qa --meta >/dev/null
trace: WARNING: wine staging is not yet at 3.0, using unstable

This comment has been minimized.

Copy link
@bendlas

bendlas Jan 26, 2018

Author Contributor

Whatever. This is irrelevant to my point.

OK, I'd appreciate your sticking to your point in your argument, then.

No, I am not

Right, it means that you're evaluating wine staging, not necessarily building or installing it, which is a larger problem. I have already agreed to take it out and I'll do so.

This comment has been minimized.

Copy link
@peti

peti Jan 26, 2018

Member

OK, I'd appreciate your sticking to your point in your argument, then.

You misunderstood. My point was (and still is) totally valid. I just don't want to argue with you about it. I just want you to remove that stupid trace message you've added.

Right, it means that you're evaluating wine staging, not necessarily building or installing it, which is a larger problem.

No kidding.

This comment has been minimized.

Copy link
@7c6f434c

7c6f434c Jan 26, 2018

Member

@peti Well, it is easy to forget/not know this message will happen on many operations, not just on actually installing this version (which makes any trace message completely unrelated to what user was doing and therefore annoying). Now @bendlas can join the ranks of those who know it. (I guess there is now no disagreement about actual code changes)

This comment has been minimized.

Copy link
@bendlas

bendlas Jan 26, 2018

Author Contributor

Hey, dude, I think I need to explain something to you. I have come to know you as a long-time member and prolific contributor, that's very valuable to the community and I respect you for that. This doesn't mean, that I'll put up with your attitude. So your options to choose from are:

a) make me do what you want me to do, or
b) antagonize me.

Both at the same time will be hard to pull off with me and many other people as well, as you certainly know. Besides, it's immoral.

So, since I already agreed with you to do a), I really don't get why you couldn't resist throwing more shade and trying to provoke me further.

How would you feel, if you agreed with someone and that person answered:

No kidding.

?
Feels shitty, doesn't it?

No need for an apology or further provocations, but in the future, please realize that as a senior member, you're setting the tone in the community and people are looking to you for guidance.

This comment has been minimized.

Copy link
@bendlas

bendlas Jan 26, 2018

Author Contributor

This comment has been minimized.

Copy link
@peti

peti Jan 26, 2018

Member

I suppose I should have made a greater effort to be polite when I wrote my initial comment. I was in the middle of doing something else entirely, and the appearance of that warning interrupted me. I was annoyed and impatient, and I didn't do a good job reporting the problem to you. As I said, I was in a hurry and had my mind elsewhere. Apparently, you perceived my initial message as rude and responded in kind. I am sorry for provoking those negative feelings; I did not mean to sound disrespectful.

This comment has been minimized.

Copy link
@bendlas

bendlas Jan 26, 2018

Author Contributor

Accepted!
Thanks for letting me know your insight.
Sorry for having interrupted your workflow.

# callPackage ./staging.nix {
# inherit libtxc_dxtn_Name wineUnstable;
# }
else
wine-build wineBuild wineRelease
6 changes: 3 additions & 3 deletions pkgs/misc/emulators/wine/sources.nix
Expand Up @@ -39,9 +39,9 @@ in rec {

unstable = fetchurl rec {
# NOTE: Don't forget to change the SHA256 for staging as well.
version = "2.21";
url = "https://dl.winehq.org/wine/source/2.x/wine-${version}.tar.xz";
sha256 = "1vxbnikdpsmca3nx064mqrm83xpjsfshy25mdfxmyg5vrzl09yms";
version = "3.0";
url = "https://dl.winehq.org/wine/source/3.0/wine-${version}.tar.xz";
sha256 = "1v7vq9iinkscbq6wg85fb0d2137660fg2nk5iabxkl2wr850asil";
inherit (stable) mono gecko32 gecko64;
};

Expand Down

0 comments on commit 4fec62d

Please sign in to comment.