syncthing-gtk: explicitly depend on gobjectIntrospection #34277

cumber · 2018-01-26T01:55:52Z

Motivation for this change

After a recent update I found syncthing-gtk can no longer start up. The error message it displayed was:

Traceback (most recent call last):
  File "/nix/store/6lagyfbkijzwxfpbc8c2lsjr3gh25fql-python2.7-syncthing-gtk-0.9.2.3/bin/..syncthing-gtk-wrapped-wrapped", line 24, in <module>
    gi.require_version('Gtk', '3.0')
  File "/nix/store/fhw737zss63iyrf2vmwdwy7wjvlcqx5b-python2.7-pygobject-3.26.1/lib/python2.7/site-packages/gi/__init__.py", line 130, in require_version
    raise ValueError('Namespace %s not available' % namespace)
ValueError: Namespace Gtk not available

I diffed the store output of the most recent working version I had, and the main difference seemed to be that the new version didn't have a reference to gobjectIntrospection in its wrappers. Searching around led me to believe the cause may be a recent change to stop atk propagating gobjectIntrospection (see #32296).

Although I'm not familiar with all of the packages/issues involved, I did come up with a patch to fix it so that syncthing-gtk seems to work again.

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

cumber · 2018-01-26T02:02:22Z

Should I also file an issue for the bug this fixes?

jtojnar

This looks great, thanks.

jtojnar · 2018-01-26T04:45:22Z

Could you please also take a look at #32016?

jtojnar · 2018-01-26T05:31:41Z

pkgs/top-level/python-packages.nix

@@ -17343,7 +17343,8 @@ in {

    propagatedBuildInputs = with self; [ pkgs.syncthing dateutil pyinotify
      pkgs.libnotify
-      (pkgs.librsvg.override { withGTK = true; })
+      (pkgs.librsvg.override { withGTK = true; enableIntrospection = true; })


Actually, withGtk implies enableIntrospection. But in this case , the latter should be enough.

Oh, right, it no longer does since #32296. But enabling introspection should be still enough.

Previously atk had gobjectIntrospection as a propagated build input, which was making its way into librsvg (even without enableIntrospection set to true) and then to syncthing-gtk.

cumber · 2018-01-26T05:51:58Z

Yeah, I wouldn't have found enableIntrospection if it didn't break after I'd just added the gobjectIntrospection dep to syncthing-gtk itself.

I've taken out withGTK = true, and syncthing-gtk did build and run fine. But it's not clear to me why that's redundant with enableIntrospection turned on; it seems that gtk3 is added to propagatedBuildInputs if withGTK is true, and isn't if withGTK is false even if gtk3 still ends up being a transitive buildInput via gobjectIntrospection. Would it be possible for gtk3 not being propagated to make a difference?

grahamc · 2018-01-27T04:05:18Z

@GrahamcOfBorg build syncthing-gtk

GrahamcOfBorg

Failure for system: x86_64-linux

error: attribute ‘syncthing-gtk’ in selection path ‘syncthing-gtk’ not found

GrahamcOfBorg

Failure for system: aarch64-linux

error: attribute 'syncthing-gtk' in selection path 'syncthing-gtk' not found

GrahamcOfBorg

Failure for system: x86_64-darwin

error: attribute 'syncthing-gtk' in selection path 'syncthing-gtk' not found

cumber · 2018-01-27T04:41:08Z

Oh, it's actually pythonPackages.syncthing-gtk, I think

fpletz · 2018-01-28T23:49:43Z

@GrahamcOfBorg build pythonPackages.syncthing-gtk

GrahamcOfBorg

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘python2.7-pyinotify-0.9.6’ in /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/top-level/python-packages.nix:13995 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg

Success on x86_64-linux (full log)

Partial log (click to expand)

writing top-level names to syncthing_gtk.egg-info/top_level.txt
writing dependency_links to syncthing_gtk.egg-info/dependency_links.txt
reading manifest file 'syncthing_gtk.egg-info/SOURCES.txt'
writing manifest file 'syncthing_gtk.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK

GrahamcOfBorg

Success on aarch64-linux (full log)

Partial log (click to expand)

writing dependency_links to syncthing_gtk.egg-info/dependency_links.txt
reading manifest file 'syncthing_gtk.egg-info/SOURCES.txt'
writing manifest file 'syncthing_gtk.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/d60170k0pk7xrf5hw288r5cyrz9n3hw4-python2.7-syncthing-gtk-0.9.2.3

fpletz · 2018-01-29T00:02:30Z

@GrahamcOfBorg build syncthing-gtk

GrahamcOfBorg

Failure on x86_64-darwin (full log)

Partial log (click to expand)

error: while evaluating the attribute 'propagatedBuildInputs' of the derivation 'syncthing-gtk-0.9.2.3' at /tmp/nix-ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/stdenv/generic/make-derivation.nix:148:11:
while evaluating 'getOutput' at /tmp/nix-ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/attrsets.nix:450:23, called from undefined position:
while evaluating anonymous function at /tmp/nix-ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/stdenv/generic/make-derivation.nix:111:17, called from undefined position:
while evaluating 'callPackageWith' at /tmp/nix-ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix:113:35, called from /tmp/nix-ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/top-level/all-packages.nix:4227:12:
while evaluating 'makeOverridable' at /tmp/nix-ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix:72:24, called from /tmp/nix-ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix:117:8:
while evaluating anonymous function at /tmp/nix-ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/os-specific/linux/psmisc/default.nix:1:1, called from /tmp/nix-ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix:74:12:
assertion failed at /tmp/nix-ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/os-specific/linux/psmisc/default.nix:3:1

GrahamcOfBorg

Success on aarch64-linux (full log)

Partial log (click to expand)

writing dependency_links to syncthing_gtk.egg-info/dependency_links.txt
reading manifest file 'syncthing_gtk.egg-info/SOURCES.txt'
writing manifest file 'syncthing_gtk.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/ki9kgnb197zm7lan4yvd8iai4ln2ln9j-syncthing-gtk-0.9.2.3

jtojnar · 2018-01-29T00:05:37Z

@fpletz see #32016 which also moves the derivation.

jtojnar · 2018-01-29T00:07:20Z

Also both of these pull requests are runtime fixes so we need someone to test them locally. (I cannot do it because syncthing hates me.)

GrahamcOfBorg

Success on x86_64-linux (full log)

Partial log (click to expand)

writing dependency_links to syncthing_gtk.egg-info/dependency_links.txt
reading manifest file 'syncthing_gtk.egg-info/SOURCES.txt'
writing manifest file 'syncthing_gtk.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/sjgr9sgl7pvp6xx8m2mlf966xr5bfzgv-syncthing-gtk-0.9.2.3

jtojnar · 2018-01-29T00:33:48Z

Merged as part of #32016.

cumber requested a review from FRidh as a code owner January 26, 2018 01:55

GrahamcOfBorg added 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 labels Jan 26, 2018

jtojnar approved these changes Jan 26, 2018

View reviewed changes

jtojnar reviewed Jan 26, 2018

View reviewed changes

syncthing-gtk: explicitly depend on gobjectIntrospection

cdb42d6

Previously atk had gobjectIntrospection as a propagated build input, which was making its way into librsvg (even without enableIntrospection set to true) and then to syncthing-gtk.

cumber force-pushed the fix/syncthing-gtk_namespace-gtk-not-available branch from 681e68d to cdb42d6 Compare January 26, 2018 05:46

GrahamcOfBorg reviewed Jan 27, 2018

View reviewed changes

GrahamcOfBorg reviewed Jan 28, 2018

View reviewed changes

syncthing-gtk: convert to app, move to top-level

22cb495

GrahamcOfBorg reviewed Jan 29, 2018

View reviewed changes

fpletz mentioned this pull request Jan 29, 2018

syncthing-gtk: 0.9.2.3 → 0.9.2.7 #32016

Merged

8 tasks

jtojnar closed this Jan 29, 2018

cumber deleted the fix/syncthing-gtk_namespace-gtk-not-available branch January 29, 2018 02:07

Janik-Haag added the 12. first-time contribution label Jun 12, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

syncthing-gtk: explicitly depend on gobjectIntrospection #34277

syncthing-gtk: explicitly depend on gobjectIntrospection #34277

cumber commented Jan 26, 2018 •

edited

cumber commented Jan 26, 2018

jtojnar left a comment

jtojnar commented Jan 26, 2018

jtojnar Jan 26, 2018

jtojnar Jan 26, 2018

cumber commented Jan 26, 2018

grahamc commented Jan 27, 2018

GrahamcOfBorg left a comment

GrahamcOfBorg left a comment

GrahamcOfBorg left a comment

cumber commented Jan 27, 2018

fpletz commented Jan 28, 2018

GrahamcOfBorg left a comment

GrahamcOfBorg left a comment

GrahamcOfBorg left a comment

fpletz commented Jan 29, 2018

GrahamcOfBorg left a comment

GrahamcOfBorg left a comment

jtojnar commented Jan 29, 2018

jtojnar commented Jan 29, 2018

GrahamcOfBorg left a comment

jtojnar commented Jan 29, 2018

syncthing-gtk: explicitly depend on gobjectIntrospection #34277

syncthing-gtk: explicitly depend on gobjectIntrospection #34277

Conversation

cumber commented Jan 26, 2018 • edited

Motivation for this change

Things done

cumber commented Jan 26, 2018

jtojnar left a comment

Choose a reason for hiding this comment

jtojnar commented Jan 26, 2018

jtojnar Jan 26, 2018

Choose a reason for hiding this comment

jtojnar Jan 26, 2018

Choose a reason for hiding this comment

cumber commented Jan 26, 2018

grahamc commented Jan 27, 2018

GrahamcOfBorg left a comment

Choose a reason for hiding this comment

GrahamcOfBorg left a comment

Choose a reason for hiding this comment

GrahamcOfBorg left a comment

Choose a reason for hiding this comment

cumber commented Jan 27, 2018

fpletz commented Jan 28, 2018

GrahamcOfBorg left a comment

Choose a reason for hiding this comment

GrahamcOfBorg left a comment

Choose a reason for hiding this comment

GrahamcOfBorg left a comment

Choose a reason for hiding this comment

fpletz commented Jan 29, 2018

GrahamcOfBorg left a comment

Choose a reason for hiding this comment

GrahamcOfBorg left a comment

Choose a reason for hiding this comment

jtojnar commented Jan 29, 2018

jtojnar commented Jan 29, 2018

GrahamcOfBorg left a comment

Choose a reason for hiding this comment

jtojnar commented Jan 29, 2018

cumber commented Jan 26, 2018 •

edited