Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.colorlog: 2.6.1 -> 3.1.0 #34278

Merged
merged 1 commit into from Jan 29, 2018
Merged

pythonPackages.colorlog: 2.6.1 -> 3.1.0 #34278

merged 1 commit into from Jan 29, 2018

Conversation

dotlambda
Copy link
Member

The disabled tests fail:

=================================== FAILURES ===================================
_____________________________ test_logging_module ______________________________

test_logger = <function test_logger.<locals>.function at 0x7ffff180ed08>

    def test_logging_module(test_logger):
>       test_logger(logging)

colorlog/tests/test_logging.py:9: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
colorlog/tests/conftest.py:36: in function
    assert_log_message(logger.debug, 'a debug message', capsys),
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

log_function = <function debug at 0x7ffff2d92840>, message = 'a debug message'
capsys = <_pytest.capture.CaptureFixture object at 0x7ffff2a67550>

    def assert_log_message(log_function, message, capsys):
        """Call a log function and check the message has been output."""
        log_function(message)
        out, err = capsys.readouterr()
        # Print the output so that py.test shows it when a test fails
        print(err, end='', file=sys.stderr)
        # Assert the message send to the logger was output
>       assert message in err, 'Log message not output to STDERR'
E       AssertionError: Log message not output to STDERR
E       assert 'a debug message' in ''

colorlog/tests/conftest.py:22: AssertionError
------------------------------ Captured log call -------------------------------
conftest.py                 17 DEBUG    a debug message
_____________________________ test_colorlog_module _____________________________

test_logger = <function test_logger.<locals>.function at 0x7ffff180ed90>

    def test_colorlog_module(test_logger):
>       test_logger(colorlog)

colorlog/tests/test_logging.py:13: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
colorlog/tests/conftest.py:36: in function
    assert_log_message(logger.debug, 'a debug message', capsys),
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

log_function = <function debug at 0x7ffff2abc400>, message = 'a debug message'
capsys = <_pytest.capture.CaptureFixture object at 0x7ffff2a67be0>

    def assert_log_message(log_function, message, capsys):
        """Call a log function and check the message has been output."""
        log_function(message)
        out, err = capsys.readouterr()
        # Print the output so that py.test shows it when a test fails
        print(err, end='', file=sys.stderr)
        # Assert the message send to the logger was output
>       assert message in err, 'Log message not output to STDERR'
E       AssertionError: Log message not output to STDERR
E       assert 'a debug message' in ''

colorlog/tests/conftest.py:22: AssertionError
------------------------------ Captured log call -------------------------------
logging.py                  33 DEBUG    a debug message
__________________________ test_colorlog_basicConfig ___________________________

test_logger = <function test_logger.<locals>.function at 0x7ffff180ef28>

    def test_colorlog_basicConfig(test_logger):
        colorlog.basicConfig()
>       test_logger(colorlog.getLogger())

colorlog/tests/test_logging.py:18: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
colorlog/tests/conftest.py:36: in function
    assert_log_message(logger.debug, 'a debug message', capsys),
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

log_function = <bound method Logger.debug of <RootLogger root (WARNING)>>
message = 'a debug message'
capsys = <_pytest.capture.CaptureFixture object at 0x7ffff17d2550>

    def assert_log_message(log_function, message, capsys):
        """Call a log function and check the message has been output."""
        log_function(message)
        out, err = capsys.readouterr()
        # Print the output so that py.test shows it when a test fails
        print(err, end='', file=sys.stderr)
        # Assert the message send to the logger was output
>       assert message in err, 'Log message not output to STDERR'
E       AssertionError: Log message not output to STDERR
E       assert 'a debug message' in ''

colorlog/tests/conftest.py:22: AssertionError
------------------------------ Captured log call -------------------------------
DEBUG:root:a debug message
===================== 3 failed, 24 passed in 0.19 seconds ======================

I don't understand what the problem is.
Maybe @FRidh can help.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@dotlambda dotlambda requested a review from FRidh as a code owner January 26, 2018 02:38
@FRidh
Copy link
Member

FRidh commented Jan 26, 2018

Seems like a valid bug in their code.

@dotlambda
Copy link
Member Author

I just opened borntyping/python-colorlog#56.

@dotlambda
Copy link
Member Author

All issues are resolved.

@FRidh
Copy link
Member

FRidh commented Jan 26, 2018

@GrahamcOfBorg build pythonPackages.colorlog python3Packages.colorlog

GrahamcOfBorg
GrahamcOfBorg reviewed Jan 26, 2018
View reviewed changes
Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: aarch64-linux

colorlog/tests/test_colorlog.py ...........                              [ 40%]
colorlog/tests/test_config.py ..                                         [ 48%]
colorlog/tests/test_escape_codes.py .........                            [ 81%]
colorlog/tests/test_example.py .                                         [ 85%]
colorlog/tests/test_exports.py .                                         [ 88%]
colorlog/tests/test_logging.py ...                                       [100%]

========================== 27 passed in 0.78 seconds ===========================
/nix/store/if9h11sbqlw482vd0gb58k8w5ni7m2c2-python2.7-colorlog-3.1.2
/nix/store/gjwdab4j0yf995v1bjivyqzd9501471g-python3.6-colorlog-3.1.2

GrahamcOfBorg
GrahamcOfBorg reviewed Jan 26, 2018
View reviewed changes
Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-linux

colorlog/tests/test_colorlog.py ...........                              [ 40%]
colorlog/tests/test_config.py ..                                         [ 48%]
colorlog/tests/test_escape_codes.py .........                            [ 81%]
colorlog/tests/test_example.py .                                         [ 85%]
colorlog/tests/test_exports.py .                                         [ 88%]
colorlog/tests/test_logging.py ...                                       [100%]

========================== 27 passed in 0.19 seconds ===========================
/nix/store/2609dq505dmgknkbbaypqb9sqhk3xdi0-python2.7-colorlog-3.1.2
/nix/store/3bsf31h05g4k0ad4g06a7bwdrd60jmc1-python3.6-colorlog-3.1.2

GrahamcOfBorg
GrahamcOfBorg reviewed Jan 26, 2018
View reviewed changes
Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-darwin

colorlog/tests/test_colorlog.py ...........                              [ 40%]
colorlog/tests/test_config.py ..                                         [ 48%]
colorlog/tests/test_escape_codes.py .........                            [ 81%]
colorlog/tests/test_example.py .                                         [ 85%]
colorlog/tests/test_exports.py .                                         [ 88%]
colorlog/tests/test_logging.py ...                                       [100%]

========================== 27 passed in 0.79 seconds ===========================
/nix/store/xdk85sbpfd4hnvnqqqcnczswf3xzvbx1-python2.7-colorlog-3.1.2
/nix/store/hkpxryqfk5bwy764397wx5s6slia426p-python3.6-colorlog-3.1.2

@FRidh FRidh merged commit 79575ee into NixOS:master Jan 29, 2018
@dotlambda dotlambda deleted the colorlog branch February 8, 2018 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrahamcOfBorg GrahamcOfBorg GrahamcOfBorg left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dotlambda @FRidh @GrahamcOfBorg