link_to on multiple lines does not look good

mojolicious · Jan 25, 2018 · dfcd53a · dfcd53a
1 parent 21db820
commit dfcd53a
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 27 deletions.
diff --git a/lib/Mojolicious/Plugin/Minion/resources/templates/minion/_limit.html.ep b/lib/Mojolicious/Plugin/Minion/resources/templates/minion/_limit.html.ep
@@ -6,8 +6,8 @@
       % }
       % else {
         <li class="page-item">
-          <%= link_to $i => url_with->query([limit => $i])
-            => (class => 'page-link') %>
+          % my $url = url_with->query([limit => $i]);
+          <a class="page-link" href="<%= $url %>"><%= $i %></a>
         </li>
       % }
     % }

diff --git a/lib/Mojolicious/Plugin/Minion/resources/templates/minion/_pagination.html.ep b/lib/Mojolicious/Plugin/Minion/resources/templates/minion/_pagination.html.ep
@@ -14,9 +14,8 @@
     % }
     % else {
       <li class="page-item">
-        <a class="page-link" href="<%= url_with->query([offset => 0]) %>">
-          First
-        </a>
+        % my $url = url_with->query([offset => 0]);
+        <a class="page-link" href="<%= $url %>">First</a>
     % }
     </li>
     % if ($current_page == 1) {
@@ -25,10 +24,8 @@
     % }
     % else {
       <li class="page-item">
-        <a class="page-link"
-          href="<%= url_with->query([offset => $prev_offset]) %>">
-          Previous
-        </a>
+        % my $url = url_with->query([offset => $prev_offset]);
+        <a class="page-link" href="<%= $url %>">Previous</a>
     % }
     </li>
     % my $start = $current_page >= 3 ? $current_page - 2 : 1;
@@ -41,10 +38,8 @@
       % }
       % else {
         <li class="page-item">
-          <a class="page-link"
-            href="<%= url_with->query([offset => ($i - 1) * $limit]) %>">
-            <%= $i %>
-          </a>
+          % my $url = url_with->query([offset => ($i - 1) * $limit]);
+          <a class="page-link" href="<%= $url %>"><%= $i %></a>
         </li>
       % }
     % }
@@ -54,10 +49,8 @@
     % }
     % else {
       <li class="page-item">
-        <a class="page-link"
-          href="<%= url_with->query([offset => $next_offset]) %>">
-          Next
-        </a>
+        % my $url = url_with->query([offset => $next_offset]);
+        <a class="page-link" href="<%= $url %>">Next</a>
     % }
     </li>
     % if ($current_page >= $last_page) {
@@ -66,10 +59,8 @@
     % }
     % else {
       <li class="page-item">
-        <a class="page-link"
-          href="<%= url_with->query([offset => $last_offset]) %>">
-          Last
-        </a>
+        % my $url = url_with->query([offset => $last_offset]);
+        <a class="page-link" href="<%= $url %>">Last</a>
     % }
     </li>
   </ul>

diff --git a/lib/Mojolicious/Plugin/Minion/resources/templates/minion/jobs.html.ep b/lib/Mojolicious/Plugin/Minion/resources/templates/minion/jobs.html.ep
@@ -14,16 +14,16 @@
       </button>
       <div class="dropdown-menu" aria-labelledby="dropdownMenuButton">
         % if (@$parents) {
-          <%= link_to Parents => url_for('minion_jobs')->query(id => $parents)
-            => (class => 'dropdown-item') %>
+          % my $url = url_for('minion_jobs')->query(id => $parents);
+          <a class="dropdown-item" href="<%= $url %>">Parents</a>
         % }
         % if (@$children) {
-          <%= link_to Children => url_for('minion_jobs')->query(id => $children)
-            => (class => 'dropdown-item') %>
+          % my $url = url_for('minion_jobs')->query(id => $children);
+          <a class="dropdown-item" href="<%= $url %>">Children</a>
         % }
         % if ($id) {
-          <%= link_to Worker => url_for('minion_workers')->query(id => $id)
-            => (class => 'dropdown-item') %>
+          % my $url = url_for('minion_workers')->query(id => $id);
+          <a class="dropdown-item" href="<%= $url %>">Worker</a>
         % }
       </div>
     </div>