lib: Allow parsing platform configs with arch of {riscv,wasm}{32,64}
#34269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ericson2314
commented
Jan 25, 2018
lib/systems/inspect.nix
Outdated
| i686 = { cpu = cpuTypes.i686; }; | ||
| x86_64 = { cpu = cpuTypes.x86_64; }; | ||
| PowerPC = { cpu = cpuTypes.powerpc; }; | ||
| x86 = { cpu = { family = "x86"; }; }; | ||
| Arm = { cpu = { family = "arm"; }; }; | ||
| Aarch64 = { cpu = { family = "aarch64"; }; }; | ||
| Mips = { cpu = { family = "mips"; }; }; | ||
| Riscv = { cpu = { family = "riscv"; }; }; |
There was a problem hiding this comment.
Or do we do RiscV? Bikeshed! 😁
There was a problem hiding this comment.
The official style seems to be "RISC-V" -- if that doesn't fit the mold, I suppose "RiscV" at least captures the separation of the "RISC" and "V", so "RiscV" seems like a decent compromise and might be better than "Riscv".
With that said, I'm not adamant about it.
|
Oh pretty ;) |
Also add `isRiscv` and `isWasm` predicates.
Ericson2314
force-pushed
the
lib-riscv-wasm
branch
from
72d4d8d
to
d1478c9
Compare
Ericson2314
added
the
6.topic: cross-compilation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add
isRiscvandisWasmpredicates.Motivation for this change
We want to compile to more platforms! This is the first step.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)CC @ElvishJerricco @boomshroom