Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

darktable: lua support requires lua 5.3 #33716

Merged
merged 1 commit into from Jan 12, 2018
Merged

darktable: lua support requires lua 5.3 #33716

merged 1 commit into from Jan 12, 2018

Conversation

pbogdan
Copy link
Member

@pbogdan pbogdan commented Jan 10, 2018

Motivation for this change

#33710 (comment)

Fixes #33710.

Things done
$ ./result/bin/darktable --version                                                                                                                                              
this is darktable 2.4.0                                                                                                                                                                                             
copyright (c) 2009-2017 johannes hanika                                                                                                                                                                             
darktable-dev@lists.darktable.org                                                                                                                                                                                   

compile options:                                                                                                                                                                                                    
  bit depth is 64 bit                                                                                                                                                                                               
  normal build                                                                                                                                                                                                      
  SSE2 optimized codepath enabled                                                                                                                                                                                   
  OpenMP support enabled                                                                                                                                                                                            
  OpenCL support enabled                                                                                                                                                                                            
  Lua support enabled, API version 5.0.0                                                                                                                                                                            
  Colord support enabled                                                                                                                                                                                            
  gPhoto2 support enabled                                                                                                                                                                                           
  GraphicsMagick support enabled                                                                                                                                                                                    
  OpenEXR support enabled
  • Executed a "hello world" lua script
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@adisbladis adisbladis merged commit b3b3de6 into NixOS:master Jan 12, 2018
@pbogdan pbogdan deleted the darktable-lua branch December 3, 2019 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pbogdan @adisbladis @GrahamcOfBorg