Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haskell-modules: swagger2 still needs dontHaddock on armv7l-linux. #33735

Merged
merged 1 commit into from Jan 11, 2018
Merged

haskell-modules: swagger2 still needs dontHaddock on armv7l-linux. #33735

merged 1 commit into from Jan 11, 2018

Conversation

dhess
Copy link
Contributor

@dhess dhess commented Jan 11, 2018

Motivation for this change

Sometime while I was fixing these armv7l-linux modules, configuration-common.nix was re-organized and the author dropped the dontHaddock that used to be there on swagger2. I didn't notice until after the armv7l-linux dontCheck for swagger2 was applied.

Anyway, dontHaddock is still needed for that package on armv7l-linux.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@dhess dhess requested a review from peti as a code owner January 11, 2018 09:04
@peti peti merged commit db8a429 into NixOS:master Jan 11, 2018
@dhess dhess deleted the swagger2-armv7l branch January 17, 2018 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants