Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clipster: 1.4.1 -> 1.5.0 #33718

Merged
merged 2 commits into from Jan 25, 2018
Merged

clipster: 1.4.1 -> 1.5.0 #33718

merged 2 commits into from Jan 25, 2018

Conversation

magnetophon
Copy link
Member

@magnetophon magnetophon commented Jan 10, 2018 •
edited

Motivation for this change

the previous version is broken, when you run the daemon, it says:

Traceback (most recent call last):
  File "/nix/store/bzxnrc2lzcd8d8zbfx65vxypijjkhya6-clipster-1.4.1/bin/.clipster-wrapped", line 21, in <module>
    require_version("Gtk", "3.0")
  File "/nix/store/s5a6d9v9m939kw6ih9mq9v2bcnbi7cdv-python3-3.6.4-env/lib/python3.6/site-packages/gi/__init__.py", line 130, in require_version
    raise ValueError('Namespace %s not available' % namespace)
ValueError: Namespace Gtk not available
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@magnetophon
clipster: fixup
66589e4 
the previous version is broken, when you run the daemon, it says:

```
Traceback (most recent call last):
  File "/nix/store/bzxnrc2lzcd8d8zbfx65vxypijjkhya6-clipster-1.4.1/bin/.clipster-wrapped", line 21, in <module>
    require_version("Gtk", "3.0")
  File "/nix/store/s5a6d9v9m939kw6ih9mq9v2bcnbi7cdv-python3-3.6.4-env/lib/python3.6/site-packages/gi/__init__.py", line 130, in require_version
    raise ValueError('Namespace %s not available' % namespace)
ValueError: Namespace Gtk not available
```
@magnetophon
Copy link
Member Author

Any news on this?

@magnetophon magnetophon changed the title clipster: fixup clipster: 1.4.1 -> 1.5.0 Jan 24, 2018
@magnetophon
Copy link
Member Author

Added an upgrade to this branch.

@adisbladis adisbladis merged commit e401af5 into NixOS:master Jan 25, 2018
@adisbladis
Copy link
Member

Thanks :)

@magnetophon
Copy link
Member Author

@adisbladis Thank you!
I was starting to think this would never get merged...

@magnetophon magnetophon deleted the clipster branch January 25, 2018 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@magnetophon @adisbladis @GrahamcOfBorg