Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

taskwarrior: Fix bash completion #33717

Merged
merged 1 commit into from Jan 21, 2018
Merged

taskwarrior: Fix bash completion #33717

merged 1 commit into from Jan 21, 2018

Conversation

matthiasbeyer
Copy link
Contributor

Motivation for this change

Closes #33704

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@hedning hedning mentioned this pull request Jan 12, 2018
Closed
8 tasks
@srhb srhb merged commit 8c25e0d into NixOS:master Jan 21, 2018
@srhb
Copy link
Contributor

srhb commented Jan 21, 2018

Thanks! Should this be backported?

@matthiasbeyer
Copy link
Contributor Author

I'm not sure whether the issue exists on the stable branches as well. If yes, I think so.

@matthiasbeyer matthiasbeyer deleted the fix-taskwarrior-completion branch January 21, 2018 11:41
@srhb
Copy link
Contributor

srhb commented Jan 21, 2018

What are the necessary magics to check? With or without this PR, nix-shell -p taskwarrior does not appear to provide bash completions to the task command. Do I need to do something else as well?

@matthiasbeyer
Copy link
Contributor Author

That's because nix-shell does not import completions at all afaik.

For what I know, taskwarrior has to be installed to check whether completions are available.

@srhb
Copy link
Contributor

srhb commented Jan 21, 2018

OK, thanks for clarifying -- I generally use zsh. It does indeed need a backport,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@matthiasbeyer @srhb @GrahamcOfBorg