Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ldc: Remove dynamiccompile tests for Darwin too #33723

Merged
merged 1 commit into from Jan 10, 2018

Conversation

ThomasMader
Copy link
Contributor

@joachifm This fixes the ldc build on Darwin introduced through #33532.

@LnL7
Copy link
Member

LnL7 commented Jan 10, 2018

@GrahamcOfBorg build ldc

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: aarch64-linux

Package ‘ldcBuild-1.7.0’ in /var/lib/gc-of-borg/nix-test-rs-3/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-3/pkgs/development/compilers/ldc/default.nix:164 is not supported on ‘aarch64-linux’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: x86_64-darwin

  CMakeLists.txt:2 (project)


-- Configuring incomplete, errors occurred!
See also "/tmp/nix-build-ldcBuild-1.7.0.drv-0/ldc-1.7.0-src/build/CMakeFiles/CMakeOutput.log".
See also "/tmp/nix-build-ldcBuild-1.7.0.drv-0/ldc-1.7.0-src/build/CMakeFiles/CMakeError.log".
builder for '/nix/store/zs77inzs55rf68fvz0x0w0ckw5ic6g1f-ldcBuild-1.7.0.drv' failed with exit code 1
cannot build derivation '/nix/store/s1m7fsn4z25lrkqnr0gd0fnhzg3z1svd-ldcUnittests-1.7.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/k9vmma4bvb8kr3pjk12r8iryjwnm7v1q-ldc-1.7.0.drv': 2 dependencies couldn't be built
error: build of '/nix/store/k9vmma4bvb8kr3pjk12r8iryjwnm7v1q-ldc-1.7.0.drv' failed

@ThomasMader
Copy link
Contributor Author

Failure for system: x86_64-darwin

This is for some reason never working for the bot build but does so on hydra. As seen for the last dmd and dtools updates.

@LnL7
Copy link
Member

LnL7 commented Jan 10, 2018

These builds have sandboxing enabled, there's probably some impurity that's causing the failure.

@joachifm joachifm merged commit 7fd0c78 into NixOS:master Jan 10, 2018
Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-linux

Total Test time (real) =  25.92 sec
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/0yj3pxlsmf9k45xmd0qkpcmg577k9cwz-ldcUnittests-1.7.0
strip is /nix/store/wxn5gn8amxm1w0ikcx4gbs8a17wvss4j-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/0yj3pxlsmf9k45xmd0qkpcmg577k9cwz-ldcUnittests-1.7.0
checking for references to /tmp/nix-build-ldcUnittests-1.7.0.drv-0 in /nix/store/0yj3pxlsmf9k45xmd0qkpcmg577k9cwz-ldcUnittests-1.7.0...
building path(s) ‘/nix/store/y50gnwqk03n3ycpja1z01l8wiyxw4nfn-ldc-1.7.0’
installing
/nix/store/y50gnwqk03n3ycpja1z01l8wiyxw4nfn-ldc-1.7.0

@ThomasMader
Copy link
Contributor Author

Question remains why it is not building on hydra for Linux. https://hydra.nixos.org/job/nixpkgs/trunk/ldc.x86_64-linux

I built it on my NixOS machine with sandboxing for the PR and just before again to test against current master but both builds were successful. The bot build was also successful but hydra failed two times. Very strange.
Has someone an idea?

@ThomasMader
Copy link
Contributor Author

This is the problem on the hydra linux build:

790: sh: line 1: 36610 Illegal instruction /build/ldc-1.7.0-src/build/dmd-testsuite/runnable/test_cdvecfill_1 > /build/ldc-1.7.0-src/build/dmd-testsuite/a0519aad7a20f86b87a15113f878a3d1815937849f5527e5ac5dbbdc24e22f05 2>&1

790: ... runnable/test_cdvecfill.d -O (-mcpu=avx -mcpu=avx2) -conf=/build/ldc-1.7.0-src/build/bin/ldc2.conf -O
790: Test failed. The logged output:
790: /build/ldc-1.7.0-src/build/bin/ldmd2 -conf= -m64 -Irunnable -O -od/build/ldc-1.7.0-src/build/dmd-testsuite/runnable -of/build/ldc-1.7.0-src/build/dmd-testsuite/runnable/test_cdvecfill_0 runnable/test_cdvecfill.d
790: /build/ldc-1.7.0-src/build/dmd-testsuite/runnable/test_cdvecfill_0
790:
790: /build/ldc-1.7.0-src/build/bin/ldmd2 -conf= -m64 -Irunnable -O -mcpu=avx -od/build/ldc-1.7.0-src/build/dmd-testsuite/runnable -of/build/ldc-1.7.0-src/build/dmd-testsuite/runnable/test_cdvecfill_1 runnable/test_cdvecfill.d
790: /build/ldc-1.7.0-src/build/dmd-testsuite/runnable/test_cdvecfill_1
790:
790:
790: ==============================
790: Test failed: expected rc == 0, exited with rc == 132

@ThomasMader
Copy link
Contributor Author

According to ldc-developers/ldc#2493 the problem is that the test shouldn't be run.

@dnadlinger
Copy link
Contributor

(This is a test that we – LDC – inherited from the upstream compiler frontend, where they assume AVX and AVX 2 to be available on build slaves.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants