Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minio: 2017-09-29T19-16-56Z -> 2018-01-02T23-07-00Z #33724

Merged
merged 2 commits into from Jan 12, 2018
Merged

minio: 2017-09-29T19-16-56Z -> 2018-01-02T23-07-00Z #33724

merged 2 commits into from Jan 12, 2018

Conversation

bachp
Copy link
Member

@bachp bachp commented Jan 10, 2018

Motivation for this change

https://github.com/minio/minio/releases/tag/RELEASE.2018-01-02T23-07-00Z

@grahamc Contains security fixes (see: https://blog.minio.io/minio-release-jan-2nd-2018-security-advisory-ef0342a4ddba) so it might be worth to backport to 17.09

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Jan 11, 2018

@GrahamcOfBorg build minio

GrahamcOfBorg
GrahamcOfBorg reviewed Jan 11, 2018
View reviewed changes
Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: aarch64-linux

Package ‘minio-2018-01-02T23-07-00Z’ in /var/lib/gc-of-borg/nix-test-rs-3/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-3/pkgs/servers/minio/default.nix:33 is not supported on ‘aarch64-linux’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg
GrahamcOfBorg reviewed Jan 11, 2018
View reviewed changes
Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-linux

building
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/w5f2lcwf7d44qr531yqi16nkhqsk5fvd-minio-2018-01-02T23-07-00Z
shrinking /nix/store/w5f2lcwf7d44qr531yqi16nkhqsk5fvd-minio-2018-01-02T23-07-00Z/bin/minio
strip is /nix/store/wxn5gn8amxm1w0ikcx4gbs8a17wvss4j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/w5f2lcwf7d44qr531yqi16nkhqsk5fvd-minio-2018-01-02T23-07-00Z/bin 
patching script interpreter paths in /nix/store/w5f2lcwf7d44qr531yqi16nkhqsk5fvd-minio-2018-01-02T23-07-00Z
checking for references to /tmp/nix-build-minio-2018-01-02T23-07-00Z.drv-0 in /nix/store/w5f2lcwf7d44qr531yqi16nkhqsk5fvd-minio-2018-01-02T23-07-00Z...
/nix/store/w5f2lcwf7d44qr531yqi16nkhqsk5fvd-minio-2018-01-02T23-07-00Z

@Mic92
minio: use buildGoPackage
a31a603 
Otherwise we will have the go build toolchain in our runtime closure.
@Mic92
Copy link
Member

Mic92 commented Jan 11, 2018

@GrahamcOfBorg build minio

GrahamcOfBorg
GrahamcOfBorg reviewed Jan 11, 2018
View reviewed changes
Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-linux

/nix/store/2mph0656qbv2v29ijsmpdzwzy4hbzrd1-minio-2018-01-02T23-07-00Z/share/go/src/github.com/minio/minio/vendor/github.com/streadway/amqp/gen.sh: interpreter directive changed from "/bin/sh" to "/nix/store/nkq0n2m4shlbdvdq0qijib5zyzgmn0vq-bash-4.4-p12/bin/sh"
/nix/store/2mph0656qbv2v29ijsmpdzwzy4hbzrd1-minio-2018-01-02T23-07-00Z/share/go/src/github.com/minio/minio/vendor/github.com/streadway/amqp/certs.sh: interpreter directive changed from "/bin/sh" to "/nix/store/nkq0n2m4shlbdvdq0qijib5zyzgmn0vq-bash-4.4-p12/bin/sh"
/nix/store/2mph0656qbv2v29ijsmpdzwzy4hbzrd1-minio-2018-01-02T23-07-00Z/share/go/src/github.com/minio/minio/dockerscripts/docker-entrypoint.sh: interpreter directive changed from "/bin/sh" to "/nix/store/nkq0n2m4shlbdvdq0qijib5zyzgmn0vq-bash-4.4-p12/bin/sh"
/nix/store/2mph0656qbv2v29ijsmpdzwzy4hbzrd1-minio-2018-01-02T23-07-00Z/share/go/src/github.com/minio/minio/dockerscripts/healthcheck.sh: interpreter directive changed from "/bin/sh" to "/nix/store/nkq0n2m4shlbdvdq0qijib5zyzgmn0vq-bash-4.4-p12/bin/sh"
/nix/store/2mph0656qbv2v29ijsmpdzwzy4hbzrd1-minio-2018-01-02T23-07-00Z/share/go/src/github.com/minio/minio/docs/orchestration/minikube/minio_distributed.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/nkq0n2m4shlbdvdq0qijib5zyzgmn0vq-bash-4.4-p12/bin/bash"
/nix/store/2mph0656qbv2v29ijsmpdzwzy4hbzrd1-minio-2018-01-02T23-07-00Z/share/go/src/github.com/minio/minio/buildscripts/verify-build.sh: interpreter directive changed from "/bin/bash" to "/nix/store/nkq0n2m4shlbdvdq0qijib5zyzgmn0vq-bash-4.4-p12/bin/bash"
/nix/store/2mph0656qbv2v29ijsmpdzwzy4hbzrd1-minio-2018-01-02T23-07-00Z/share/go/src/github.com/minio/minio/buildscripts/benchcmp.sh: interpreter directive changed from "/bin/bash          " to "/nix/store/nkq0n2m4shlbdvdq0qijib5zyzgmn0vq-bash-4.4-p12/bin/bash"
/nix/store/2mph0656qbv2v29ijsmpdzwzy4hbzrd1-minio-2018-01-02T23-07-00Z/share/go/src/github.com/minio/minio/buildscripts/go-coverage.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/nkq0n2m4shlbdvdq0qijib5zyzgmn0vq-bash-4.4-p12/bin/bash"
checking for references to /tmp/nix-build-minio-2018-01-02T23-07-00Z.drv-0 in /nix/store/2mph0656qbv2v29ijsmpdzwzy4hbzrd1-minio-2018-01-02T23-07-00Z...
/nix/store/0vn6svi15hizdr3j6iri0l6hwci2nkh9-minio-2018-01-02T23-07-00Z-bin

GrahamcOfBorg
GrahamcOfBorg reviewed Jan 11, 2018
View reviewed changes
Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: aarch64-linux

/nix/store/79dk0zbclhbppggr69rbv5czfn2x1271-minio-2018-01-02T23-07-00Z/share/go/src/github.com/minio/minio/vendor/google.golang.org/appengine/internal/regen.sh: interpreter directive changed from "/bin/bash -e" to "/nix/store/b2rfm1s05ria7d00r4p9r7f5lg7llazi-bash-4.4-p12/bin/bash -e"
/nix/store/79dk0zbclhbppggr69rbv5czfn2x1271-minio-2018-01-02T23-07-00Z/share/go/src/github.com/minio/minio/vendor/google.golang.org/grpc/codegen.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/b2rfm1s05ria7d00r4p9r7f5lg7llazi-bash-4.4-p12/bin/bash"
/nix/store/79dk0zbclhbppggr69rbv5czfn2x1271-minio-2018-01-02T23-07-00Z/share/go/src/github.com/minio/minio/vendor/google.golang.org/grpc/coverage.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/b2rfm1s05ria7d00r4p9r7f5lg7llazi-bash-4.4-p12/bin/bash"
/nix/store/79dk0zbclhbppggr69rbv5czfn2x1271-minio-2018-01-02T23-07-00Z/share/go/src/github.com/minio/minio/vendor/cloud.google.com/go/internal/version/update_version.sh: interpreter directive changed from "/bin/bash" to "/nix/store/b2rfm1s05ria7d00r4p9r7f5lg7llazi-bash-4.4-p12/bin/bash"
/nix/store/79dk0zbclhbppggr69rbv5czfn2x1271-minio-2018-01-02T23-07-00Z/share/go/src/github.com/minio/minio/vendor/github.com/streadway/amqp/certs.sh: interpreter directive changed from "/bin/sh" to "/nix/store/b2rfm1s05ria7d00r4p9r7f5lg7llazi-bash-4.4-p12/bin/sh"
/nix/store/79dk0zbclhbppggr69rbv5czfn2x1271-minio-2018-01-02T23-07-00Z/share/go/src/github.com/minio/minio/vendor/github.com/streadway/amqp/gen.sh: interpreter directive changed from "/bin/sh" to "/nix/store/b2rfm1s05ria7d00r4p9r7f5lg7llazi-bash-4.4-p12/bin/sh"
/nix/store/79dk0zbclhbppggr69rbv5czfn2x1271-minio-2018-01-02T23-07-00Z/share/go/src/github.com/minio/minio/vendor/golang.org/x/sys/unix/mkall.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/b2rfm1s05ria7d00r4p9r7f5lg7llazi-bash-4.4-p12/bin/bash"
/nix/store/79dk0zbclhbppggr69rbv5czfn2x1271-minio-2018-01-02T23-07-00Z/share/go/src/github.com/minio/minio/vendor/golang.org/x/sys/unix/mkerrors.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/b2rfm1s05ria7d00r4p9r7f5lg7llazi-bash-4.4-p12/bin/bash"
checking for references to /build in /nix/store/79dk0zbclhbppggr69rbv5czfn2x1271-minio-2018-01-02T23-07-00Z...
/nix/store/rfwphivdzn65prlc154di1xbl994ig4f-minio-2018-01-02T23-07-00Z-bin

GrahamcOfBorg
GrahamcOfBorg reviewed Jan 11, 2018
View reviewed changes
Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: x86_64-darwin

configuring
no configure script, doing nothing
building
dyld: Library not loaded: @rpath/CoreFoundation.framework/Versions/A/CoreFoundation
  Referenced from: /nix/store/yr9jqvwbpndlkclkzl22x87rhw6sq8gf-go-1.9.2/share/go/bin/.go-wrapped
  Reason: no suitable image found.  Did find:
	/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation: file system sandbox blocked stat()
/nix/store/zsn4rc9p48hsq6a53357fmk314b0ahg4-stdenv-darwin/setup: line 1241: 47949 Abort trap: 6           go build -o $out/bin/minio --ldflags "-X github.com/minio/minio/cmd.Version=2018-01-02T23-07-00Z"
builder for '/nix/store/g7k72dgb2i2nzw3zk21zgv8pia6c1kv2-minio-2018-01-02T23-07-00Z.drv' failed with exit code 134
error: build of '/nix/store/g7k72dgb2i2nzw3zk21zgv8pia6c1kv2-minio-2018-01-02T23-07-00Z.drv' failed

GrahamcOfBorg
GrahamcOfBorg reviewed Jan 11, 2018
View reviewed changes
Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: x86_64-darwin

dyld: Library not loaded: @rpath/CoreFoundation.framework/Versions/A/CoreFoundation
  Referenced from: /nix/store/yr9jqvwbpndlkclkzl22x87rhw6sq8gf-go-1.9.2/share/go/bin/.go-wrapped
  Reason: no suitable image found.  Did find:
	/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation: file system sandbox blocked stat()
dyld: Library not loaded: @rpath/CoreFoundation.framework/Versions/A/CoreFoundation
  Referenced from: /nix/store/yr9jqvwbpndlkclkzl22x87rhw6sq8gf-go-1.9.2/share/go/bin/.go-wrapped
  Reason: no suitable image found.  Did find:
	/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation: file system sandbox blocked stat()
builder for '/nix/store/h7s6nmbqjw0yj28mjfymrkz2h15jk3js-minio-2018-01-02T23-07-00Z.drv' failed with exit code 32
error: build of '/nix/store/h7s6nmbqjw0yj28mjfymrkz2h15jk3js-minio-2018-01-02T23-07-00Z.drv' failed

@Mic92
Copy link
Member

Mic92 commented Jan 11, 2018

@LnL7 adding ++ stdenv.lib.optionals stdenv.isDarwin [ CoreFoundation ]; is the proper fix here?

@LnL7
Copy link
Member

LnL7 commented Jan 11, 2018

Yes, however I don't think that should be necessary.

@bachp
Copy link
Member Author

bachp commented Jan 11, 2018 •
edited

Was darwin working before the update? I don't have a Mac at hand so I can't test it.

LnL7
LnL7 approved these changes Jan 11, 2018
View reviewed changes
Copy link
Member

@LnL7 LnL7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for x86_64-darwin without sandboxing

/nix/store/rapb2hfcjxw4j6rbhhdhai9d4hf5d34s-minio-2018-01-02T23-07-00Z/share/go/src/github.com/minio/minio/vendor/cloud.google.com/go/internal/version/update_version.sh: interpreter directive changed from "/bin/bash" to "/nix/store/hgsbnqhg7zr5vbjazb250ac4wnj3cfhy-bash-4.4-p12/bin/bash"
/nix/store/rapb2hfcjxw4j6rbhhdhai9d4hf5d34s-minio-2018-01-02T23-07-00Z/share/go/src/github.com/minio/minio/vendor/github.com/streadway/amqp/certs.sh: interpreter directive changed from "/bin/sh" to "/nix/store/hgsbnqhg7zr5vbjazb250ac4wnj3cfhy-bash-4.4-p12/bin/sh"
/nix/store/rapb2hfcjxw4j6rbhhdhai9d4hf5d34s-minio-2018-01-02T23-07-00Z/share/go/src/github.com/minio/minio/vendor/github.com/streadway/amqp/gen.sh: interpreter directive changed from "/bin/sh" to "/nix/store/hgsbnqhg7zr5vbjazb250ac4wnj3cfhy-bash-4.4-p12/bin/sh"
/nix/store/rapb2hfcjxw4j6rbhhdhai9d4hf5d34s-minio-2018-01-02T23-07-00Z/share/go/src/github.com/minio/minio/vendor/golang.org/x/sys/unix/mkall.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/hgsbnqhg7zr5vbjazb250ac4wnj3cfhy-bash-4.4-p12/bin/bash"
/nix/store/rapb2hfcjxw4j6rbhhdhai9d4hf5d34s-minio-2018-01-02T23-07-00Z/share/go/src/github.com/minio/minio/vendor/golang.org/x/sys/unix/mkerrors.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/hgsbnqhg7zr5vbjazb250ac4wnj3cfhy-bash-4.4-p12/bin/bash"
/nix/store/rapb2hfcjxw4j6rbhhdhai9d4hf5d34s-minio-2018-01-02T23-07-00Z/share/go/src/github.com/minio/minio/vendor/google.golang.org/appengine/internal/regen.sh: interpreter directive changed from "/bin/bash -e" to "/nix/store/hgsbnqhg7zr5vbjazb250ac4wnj3cfhy-bash-4.4-p12/bin/bash -e"
/nix/store/rapb2hfcjxw4j6rbhhdhai9d4hf5d34s-minio-2018-01-02T23-07-00Z/share/go/src/github.com/minio/minio/vendor/google.golang.org/grpc/codegen.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/hgsbnqhg7zr5vbjazb250ac4wnj3cfhy-bash-4.4-p12/bin/bash"
/nix/store/rapb2hfcjxw4j6rbhhdhai9d4hf5d34s-minio-2018-01-02T23-07-00Z/share/go/src/github.com/minio/minio/vendor/google.golang.org/grpc/coverage.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/hgsbnqhg7zr5vbjazb250ac4wnj3cfhy-bash-4.4-p12/bin/bash"
/nix/store/b8j3c4fswn53x3n878dyhfq4swfp6skv-minio-2018-01-02T23-07-00Z-bin

@Mic92 Mic92 merged commit dffe1e5 into NixOS:master Jan 12, 2018
Mic92 pushed a commit that referenced this pull request Jan 12, 2018
@bachp @Mic92
minio: 2017-09-29T19-16-56Z -> 2018-01-02T23-07-00Z (#33724)
d35710b 
Contains security fixes (see: https://blog.minio.io/minio-release-jan-2nd-2018-security-advisory-ef0342a4ddba)

Use buildGoPackage, otherwise we will have the go build toolchain in our runtime closure.

(cherry picked from commit dffe1e5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrahamcOfBorg GrahamcOfBorg GrahamcOfBorg left review comments

@LnL7 LnL7 LnL7 approved these changes

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bachp @Mic92 @LnL7 @GrahamcOfBorg