stumpwm: Work around dependency load errors during build #33734
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DerGuteMoritz
force-pushed
the
fix-stumpwm
branch
from
b58b014
to
156c532
Compare
|
I wonder if the best way is just to remove stand-alone `stumpwm` and
replace it with `lispPackages.stumpwm`…
|
|
@7c6f434c Thanks for the hint, I wasn't aware of this package. I've switched to this now and it works fine. The only difference is that the lisp package doesn't contain the contrib modules, but that's easily fixed by following the steps at https://github.com/stumpwm/stumpwm/wiki/Modules. There is one thing that doesn't work as advertised with the nix package, though. The documentation says that " (set-module-dir (pathname-as-directory (concat (getenv "HOME") "/.stumpwm.d/contrib")))Thanks again, I'm closing this PR then! |
|
The documentation says that "`*module-dir*` will default to `${HOME}/.stumpwm.d/contrib`". For the nix package it points to a directory in the temporary build environment, so you need to set it in your `~/.stumpwmrc` like so:
```lisp
(set-module-dir (pathname-as-directory (concat (getenv "HOME") "/.stumpwm.d/contrib")))
```
Argh. That looks like tey save it at th ebuild-time…
|
|
On 19 April 2018 06:31 -0700, Michael Raskin wrote:
Argh. That looks like tey save it at th ebuild-time…
Indeed - whatever became of LISP being dynamic environment and all that? :-D
|
|
It is dynamic environment, it is just not too dynamic with environment variables… |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The stumpwm package has been broken since late 2017. My guess is that this was caused by #28810 but it's a bit hard to pinpoint exactly.
Note that this patch is merely a work-around. Something seems to be wrong with how the stumpwm system's dependency are loaded. As you can see, I worked around this by loading them explicitly before the build. @bradleyjensen since you recently overhauled the quicklisp-to-nix / lisp-packages code, maybe you have an idea of how to properly address this?
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)