Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.09] tablib: 0.10.0 -> 0.12.1, re-enable on Python 3 #33728

Merged
merged 1 commit into from Jan 20, 2018

Conversation

das-g
Copy link
Member

@das-g das-g commented Jan 10, 2018

PR → release-17.09 (not master)

This PR targets branch release-17.09, not branch master. The changes proposed here are also based on release-17.09 and (other than advised in the README) have not been rebased onto master.

Rebasing these changes onto master would lose a part of them, as the disabled = isPy3k; line being removed here isn't even present on master. (It was introduced with 4b5cc4e that as of today isn't an ancestor of master.)

Motivation for this change

Progress on: #28643

4b5cc4e808b1#diff-2afbba83e1b14f9e0c304c769831a0e2R3411 disabled tablib for Python 3, probably because the build was failing with

ValueError: cannot use LOCALE flag with a str pattern

at https://github.com/kennethreitz/tablib/blob/v0.10.0/tablib/packages/xlwt3/ExcelFormulaLexer.py#L52

tablib v0.10.0 seems to be back from 2014 and the failing code itself from 2011. The issue at hand has been fixed in kennethreitz/tablib#263 in 2016 for tablib v0.11.4 and later, incl. the current v0.12.1. Time for us to update, too, I guess.

New dependencies

tablib v0.12.1 needs some additional build- and runtime dependencies that are also being added to the derivation with this change:

  • xlwt, openpyxl, pyyaml, xlrd, odfpy, unicodecsv and pandas are needed for the build to succeed.
  • xlwt, openpyxl, pyyaml, xlrd and odfpy are needed for import tablib to succeed in a Python 3.6 environment with the resulting tablib installed.

The latter have therefore be added as propagatedBuildInputs, while unicodecsv and pandas have been added to buildInputs.

Things done

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

needs some additional build- and runtime dependencies that are also being added to the derivation with this commit
@FRidh
Copy link
Member

FRidh commented Jan 20, 2018

Tested and works. Thanks!

@FRidh FRidh merged commit f03a421 into NixOS:release-17.09 Jan 20, 2018
@das-g
Copy link
Member Author

das-g commented Jan 21, 2018

Thanks! Will (the applicable parts of) this change automatically make it to master or should I file another PR for that?

@FRidh
Copy link
Member

FRidh commented Jan 21, 2018

@das-g nope, please open a PR

@das-g das-g mentioned this pull request Jan 21, 2018
8 tasks
@das-g
Copy link
Member Author

das-g commented Jan 21, 2018

please open a PR

Done: #34115

@das-g das-g changed the title tablib: 0.10.0 -> 0.12.1, re-enable on Python 3 [17.09] tablib: 0.10.0 -> 0.12.1, re-enable on Python 3 May 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants