[17.09] tablib: 0.10.0 -> 0.12.1, re-enable on Python 3 #33728
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR →
release-17.09
(notmaster
)This PR targets branch
release-17.09
, not branchmaster
. The changes proposed here are also based onrelease-17.09
and (other than advised in the README) have not been rebased ontomaster
.Rebasing these changes onto
master
would lose a part of them, as thedisabled = isPy3k;
line being removed here isn't even present onmaster
. (It was introduced with 4b5cc4e that as of today isn't an ancestor ofmaster
.)Motivation for this change
Progress on: #28643
4b5cc4e808b1#diff-2afbba83e1b14f9e0c304c769831a0e2R3411 disabled
tablib
for Python 3, probably because the build was failing withat https://github.com/kennethreitz/tablib/blob/v0.10.0/tablib/packages/xlwt3/ExcelFormulaLexer.py#L52
tablib
v0.10.0
seems to be back from 2014 and the failing code itself from 2011. The issue at hand has been fixed in kennethreitz/tablib#263 in 2016 fortablib
v0.11.4
and later, incl. the currentv0.12.1
. Time for us to update, too, I guess.New dependencies
tablib
v0.12.1
needs some additional build- and runtime dependencies that are also being added to the derivation with this change:xlwt
,openpyxl
,pyyaml
,xlrd
,odfpy
,unicodecsv
andpandas
are needed for the build to succeed.xlwt
,openpyxl
,pyyaml
,xlrd
andodfpy
are needed forimport tablib
to succeed in a Python 3.6 environment with the resultingtablib
installed.The latter have therefore be added as
propagatedBuildInputs
, whileunicodecsv
andpandas
have been added tobuildInputs
.Things done
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)