dendropy: init at 4.3.0 #34533
Merged
dendropy: init at 4.3.0 #34533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unode
force-pushed
the
dendropy
branch
6 times, most recently
from
f9d45ab
to
4bd94dc
Compare
dotlambda
reviewed
Feb 2, 2018
| }: | ||
|
|
||
| buildPythonPackage rec { | ||
| name = "${pname}-${version}"; |
There was a problem hiding this comment.
I tried omitting name but that resulted in a failure when I tried locally
There was a problem hiding this comment.
There shouldn't be any. Did you rebase on latest master?
Btw, name is optional only for buildPythonPackage and buildPythonApplication.
dotlambda
reviewed
Feb 2, 2018
| sha256 = "bd5b35ce1a1c9253209b7b5f3939ac22beaa70e787f8129149b4f7ffe865d510"; | ||
| }; | ||
|
|
||
| preCheck = '' |
There was a problem hiding this comment.
This might be better suited for postPatch.
|
@GrahamcOfBorg build python2.pkgs.dendropy python3.pkgs.dendropy |
|
Failure on x86_64-linux (full log) Partial log (click to expand)
|
|
Looks like a few more tests need to be disabled. Doesn't seem like nixpkgs fault here. |
|
Failure on aarch64-linux (full log) Partial log (click to expand)
|
|
The errors are: Solution: |
|
@GrahamcOfBorg build python2.pkgs.dendropy python3.pkgs.dendropy |
|
Success on x86_64-linux (full log) Partial log (click to expand)
|
dotlambda
reviewed
Feb 5, 2018
|
|
||
| meta = { | ||
| homepage = http://dendropy.org/; | ||
| description = "a Python library for phylogenetic computing"; |
There was a problem hiding this comment.
Capitalize first letter please.
|
Success on aarch64-linux (full log) Partial log (click to expand)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Dendropy is a versatile python module to handle several phylogenetic formats and build phylogenetic pipelines.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)