pythonPackages.pwntools: fix build #34537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotlambda
reviewed
Feb 2, 2018
| , pyelftools, pypandoc, pyserial, dateutil | ||
| , requests, tox, pandoc, unicorn, intervaltree }: | ||
| , pyelftools, pyserial, dateutil | ||
| , requests, tox, unicorn, intervaltree }: | ||
|
|
||
| buildPythonPackage rec { | ||
| version = "3.11.0"; |
There was a problem hiding this comment.
Please get rid of the name in the pwntools derivation.
There was a problem hiding this comment.
Ok, I thought it was mandatory, apparently not :P
|
|
||
| disabled = isPy3k; | ||
| doCheck = false; # no setuptools tests for the package | ||
|
|
||
| # Can be removed when 3.12.0 is released | ||
| patches = [ ./remove-pypandoc.patch ]; |
There was a problem hiding this comment.
Better use fetchPatch with https://github.com/Gallopsled/pwntools/pull/1098.patch.
There was a problem hiding this comment.
Thanks, I didn't realize it existed.
pypandoc is broken (it does not work properly with pandoc 2), so we remove the dependency as it was only used for generating PyPI docs. The patch will be included upstream in the next version, so it should be removed next time this package is updated.
kristoff3r
force-pushed
the
fix-pwntools
branch
from
e1f6df7
to
d834ae3
Compare
|
@GrahamcOfBorg build python2.pkgs.pwntools |
|
Success on x86_64-linux (full log) Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Partial log (click to expand)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
pypandoc is broken (it does not work properly with pandoc 2), so we
remove the dependency as it was only used for generating PyPI docs.
The patch will be included upstream in the next version, so it should
be removed next time this package is updated.
I'm not sure what should be done about pypandoc itself. It doesn't look like it will get pandoc 2 support, and it still has another package depending on it. Mark as broken?
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)