plasma-integration: Fix font style name bug with Qt >= 5.8 #34526

ttuegel · 2018-02-02T13:54:04Z

Motivation

Qt 5.8 corrects a bug in font style name handling. Unfortunately, KDE relies on that bug. As a result, some font styles (bold, italic, etc.) will be unavailable for UI fonts. This is a patch from upstream and a configuration file update.

Testing

Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

ttuegel · 2018-02-02T15:34:47Z

@GrahamcOfBorg test plasma5

GrahamcOfBorg · 2018-02-02T15:34:54Z

Failure on aarch64-linux (full log)

Partial log (click to expand)

error: while evaluating anonymous function at /var/lib/gc-of-borg/nix-test-rs-2/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-2/nixos/release.nix:19:72, called from /var/lib/gc-of-borg/nix-test-rs-2/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-2/lib/attrsets.nix:282:43:
while evaluating 'hydraJob' at /var/lib/gc-of-borg/nix-test-rs-2/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-2/lib/customisation.nix:168:14, called from /var/lib/gc-of-borg/nix-test-rs-2/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-2/nixos/release.nix:19:80:
while evaluating 'importTest' at /var/lib/gc-of-borg/nix-test-rs-2/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-2/nixos/release.nix:15:26, called from /var/lib/gc-of-borg/nix-test-rs-2/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-2/nixos/release.nix:19:90:
while evaluating anonymous function at /var/lib/gc-of-borg/nix-test-rs-2/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-2/nixos/tests/make-test.nix:1:4, called from /var/lib/gc-of-borg/nix-test-rs-2/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-2/nixos/release.nix:15:34:
undefined variable 'lib' at /var/lib/gc-of-borg/nix-test-rs-2/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-2/nixos/tests/make-test.nix:5:14

GrahamcOfBorg · 2018-02-02T15:34:55Z

Failure on x86_64-linux (full log)

Partial log (click to expand)

error: while evaluating anonymous function at /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-zoidberg/nixos/release.nix:19:72, called from /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-zoidberg/lib/attrsets.nix:282:43:
while evaluating ‘hydraJob’ at /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-zoidberg/lib/customisation.nix:168:14, called from /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-zoidberg/nixos/release.nix:19:80:
while evaluating ‘importTest’ at /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-zoidberg/nixos/release.nix:15:26, called from /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-zoidberg/nixos/release.nix:19:90:
while evaluating anonymous function at /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-zoidberg/nixos/tests/make-test.nix:1:4, called from /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-zoidberg/nixos/release.nix:15:34:
undefined variable ‘lib’ at /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-zoidberg/nixos/tests/make-test.nix:5:14

grahamc · 2018-02-02T16:10:30Z

@ttuegel do you know if this is a bug in ofborg, or nixos, or the kde test?

ttuegel · 2018-02-02T23:18:41Z

@grahamc The test passes locally on x86_64-linux. I presume it is an ofborg problem, but I don't have positive evidence of that.

pbogdan · 2018-02-02T23:44:02Z

I think it may have been fixed in 2a09b42? (EDIT: the test error, that is).

grahamc · 2018-02-03T03:04:48Z

I think you're right. Let's try this again:

@GrahamcOfBorg test plasma5

GrahamcOfBorg · 2018-02-03T03:07:19Z

Failure on x86_64-linux (full log)

Partial log (click to expand)

building path(s) ‘/nix/store/z3nim83965cpap3j4xlp0znqmq6jkgmi-desktops’
building path(s) ‘/nix/store/40gwn8qjklck15y54czrz3w62a62056w-sddm.conf’
cannot build derivation ‘/nix/store/3g32mcj8k13923zw5nfbg6jwafnxxd76-etc.drv’: 4 dependencies couldn't be built
cannot build derivation ‘/nix/store/nf5dxks8xy69djmx4hmb76ymzc501g8r-nixos-system-machine-18.03.git.7b6618b.drv’: 2 dependencies couldn't be built
cannot build derivation ‘/nix/store/mmcln1539xm2mkwzry6yfac00911nqrn-closure-info.drv’: 1 dependencies couldn't be built
cannot build derivation ‘/nix/store/43yi0cy9arvyyxqsbkfwc4dycv8dsrh8-run-nixos-vm.drv’: 2 dependencies couldn't be built
cannot build derivation ‘/nix/store/yb99ggwy8wiqc2s9hhv73rh9mcj76b88-nixos-vm.drv’: 2 dependencies couldn't be built
cannot build derivation ‘/nix/store/zlqy87fda5bmgq68cmhpqkyh1y9m7mcg-nixos-test-driver-plasma5.drv’: 1 dependencies couldn't be built
cannot build derivation ‘/nix/store/yzcjln4df0glx0byj7vm916is71c66w3-vm-test-run-plasma5.drv’: 1 dependencies couldn't be built
error: build of ‘/nix/store/yzcjln4df0glx0byj7vm916is71c66w3-vm-test-run-plasma5.drv’ failed

GrahamcOfBorg · 2018-02-03T03:07:30Z

Failure on aarch64-linux (full log)

Partial log (click to expand)

cannot build derivation '/nix/store/2fi499hyfgfmkixff23kg0yhydm85gyb-user-units.drv': 1 dependencies couldn't be built
building '/nix/store/jpqliw0h1m7mr4ni51aj2divffrgh3v3-sddm.conf.drv'...
cannot build derivation '/nix/store/g1j51fww66d7nx86s06220h7vk7rsqq5-etc.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/jv29iz8dmzj45yq1lbjvwv8iz51ysn0y-nixos-system-machine-18.03.git.96559f2.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/nnkyzx8crv4b1jwdimnlm44vdjhc2jc6-closure-info.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/hw5pcil5zl2v7sq585wikw2wdnmfgjbr-run-nixos-vm.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/axif7a08l9y73wvgw6bh217p7fmb6nfp-nixos-vm.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/c188a5qmlv5rdk1kf7f2003vfv680iab-nixos-test-driver-plasma5.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/yz8w60b86g8xwzki0qn7j1dx1v9x6pkc-vm-test-run-plasma5.drv': 1 dependencies couldn't be built
error: build of '/nix/store/yz8w60b86g8xwzki0qn7j1dx1v9x6pkc-vm-test-run-plasma5.drv' failed

grahamc · 2018-02-03T03:10:03Z

This seems to be the core of the issue:

trying https://phabricator.kde.org/file/data/nr6lcghxw2xejj7pftfh/PHID-FILE-dexapcoktxshi5dtwhk7/D9070.diff
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (22) The requested URL returned error: 404 Not Found
error: cannot download D9070.diff from any mirror
builder for ‘/nix/store/9kz4hdn0mhh045bcqplfaggfn3y9b2gj-D9070.diff.drv’ failed with exit code 1

ttuegel · 2018-02-03T17:49:39Z

It seems like Phabricator might randomly generate patch URLs, so let's try downloading it from the interface instead.

GrahamcOfBorg · 2018-02-03T17:57:29Z

Failure on aarch64-linux (full log)

Partial log (click to expand)

copying path '/nix/store/868calwv6klw7sk1v7awj6v5vw85zkny-breeze-qt5-5.11.5-bin' from 'https://cache.nixos.org'...
copying path '/nix/store/j6g2s4kylb4chzrqrfyfdi8wsy0vvk9h-kactivities-5.42.0-dev' from 'https://cache.nixos.org'...
copying path '/nix/store/0vhs2fyjw9xyailfzwagm66cg5y8k8ks-kdeclarative-5.42.0-dev' from 'https://cache.nixos.org'...
copying path '/nix/store/l0ywx0pncw63z5905lrbf2ybik4k64wp-knewstuff-5.42.0-dev' from 'https://cache.nixos.org'...
copying path '/nix/store/7phdg1mbrlhihf4azmviwdsi4lb10ip1-plasma-framework-5.42.0-dev' from 'https://cache.nixos.org'...
copying path '/nix/store/wh1kxkx3kfmn6m3iafqr4vspszr876l8-kcmutils-5.42.0-dev' from 'https://cache.nixos.org'...
copying path '/nix/store/7b40n5dxmwj7dn5qi244mqqlbznd8r15-frameworkintegration-5.42.0-dev' from 'https://cache.nixos.org'...
copying path '/nix/store/yqvgh6z1k8k3y753gchr5n9xdhg1mkz5-breeze-qt5-5.11.5-dev' from 'https://cache.nixos.org'...
cannot build derivation '/nix/store/38bh8jv3lzgxxyvq2nyhpmhg23jrm1mb-plasma-integration-5.11.5.drv': 1 dependencies couldn't be built
error: build of '/nix/store/38bh8jv3lzgxxyvq2nyhpmhg23jrm1mb-plasma-integration-5.11.5.drv' failed

GrahamcOfBorg · 2018-02-03T17:57:30Z

Failure on x86_64-linux (full log)

Partial log (click to expand)

fetching path ‘/nix/store/mikskfygfv5lw9fjiq6dxjdvh9apqn55-breeze-qt5-5.11.5-dev’...
could not download ‘http://192.168.0.203:32062/mikskfygfv5lw9fjiq6dxjdvh9apqn55.narinfo’ (Curl error 7)

*** Downloading ‘http://cache.nixos.org/nar/1hvl41rc38q20p13vkr2zfvfgqashmvpi7zcdqj3v3451lpbz537.nar.xz’ (signed by ‘cache.nixos.org-1’) to ‘/nix/store/mikskfygfv5lw9fjiq6dxjdvh9apqn55-breeze-qt5-5.11.5-dev’...
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100  3400  100  3400    0     0   3400      0  0:00:01 --:--:--  0:00:01 11147

cannot build derivation ‘/nix/store/qqnjq068wibckf345smc7q26vmj1r3cx-plasma-integration-5.11.5.drv’: 1 dependencies couldn't be built
error: build of ‘/nix/store/qqnjq068wibckf345smc7q26vmj1r3cx-plasma-integration-5.11.5.drv’ failed

grahamc · 2018-02-03T18:01:47Z

@ttuegel ^ was this auto-building helpful, or annoying?

ttuegel · 2018-02-03T19:43:53Z

Helpful, since I was just going to request the build again anyway. 😄

I can't figure out why the hash is failing now, but that's an unrelated issue.

ttuegel · 2018-02-04T14:33:15Z

Let's try checking the patch in to Nixpkgs, since I can't get a stable link upstream. 🙄

Since Qt 5.8, font style names are handled in a way that prevents alternate styles (bold, italic, etc.) from being selected for user interface fonts. See also: https://phabricator.kde.org/D9070

GrahamcOfBorg · 2018-02-04T19:39:44Z

Success on x86_64-linux (full log)

Partial log (click to expand)

glibPreFixupPhase
/nix/store/nrs5d9a43il7ybbd2mfncxi68k2mh300-plasma-integration-5.11.5
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/nrs5d9a43il7ybbd2mfncxi68k2mh300-plasma-integration-5.11.5
shrinking /nix/store/nrs5d9a43il7ybbd2mfncxi68k2mh300-plasma-integration-5.11.5/lib/qt-5.10/plugins/platformthemes/KDEPlasmaPlatformTheme.so
strip is /nix/store/5qj61lcvzlap87rf6blvf8p577d482bv-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/nrs5d9a43il7ybbd2mfncxi68k2mh300-plasma-integration-5.11.5/lib 
patching script interpreter paths in /nix/store/nrs5d9a43il7ybbd2mfncxi68k2mh300-plasma-integration-5.11.5
checking for references to /tmp/nix-build-plasma-integration-5.11.5.drv-0 in /nix/store/nrs5d9a43il7ybbd2mfncxi68k2mh300-plasma-integration-5.11.5...
postPatchMkspecs

GrahamcOfBorg · 2018-02-04T19:40:15Z

Success on aarch64-linux (full log)

Partial log (click to expand)

glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/vg3zh6yl90cylr2caq7hx5l79b2gxc1r-plasma-integration-5.11.5
shrinking /nix/store/vg3zh6yl90cylr2caq7hx5l79b2gxc1r-plasma-integration-5.11.5/lib/qt-5.10/plugins/platformthemes/KDEPlasmaPlatformTheme.so
strip is /nix/store/xmpjypwjmp2qi1chs5kr0hacnh161ls4-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/vg3zh6yl90cylr2caq7hx5l79b2gxc1r-plasma-integration-5.11.5/lib
patching script interpreter paths in /nix/store/vg3zh6yl90cylr2caq7hx5l79b2gxc1r-plasma-integration-5.11.5
checking for references to /build in /nix/store/vg3zh6yl90cylr2caq7hx5l79b2gxc1r-plasma-integration-5.11.5...
postPatchMkspecs
/nix/store/vg3zh6yl90cylr2caq7hx5l79b2gxc1r-plasma-integration-5.11.5

ttuegel · 2018-02-04T19:46:44Z

@GrahamcOfBorg test plasma5

GrahamcOfBorg · 2018-02-04T20:10:09Z

Failure on aarch64-linux (full log)

Partial log (click to expand)

machine# [    0.639765] clocksource: Switched to clocksource arch_sys_counter
machine# [    0.673799] VFS: Disk quotas dquot_6.6.0
error: OCR failed with exit code 1 at /nix/store/gka8j27d6g1h1naf0dnmdnxvr3p7angk-nixos-test-driver/lib/perl5/site_perl/Machine.pm line 586.
OCR failed with exit code 1 at /nix/store/gka8j27d6g1h1naf0dnmdnxvr3p7angk-nixos-test-driver/lib/perl5/site_perl/Machine.pm line 586.
cleaning up
killing machine (pid 627)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
builder for '/nix/store/3p7mfnyky3kyqwhshcim68wsfssisv6s-vm-test-run-plasma5.drv' failed with exit code 2
error: build of '/nix/store/3p7mfnyky3kyqwhshcim68wsfssisv6s-vm-test-run-plasma5.drv' failed

GrahamcOfBorg · 2018-02-04T20:15:04Z

Success on x86_64-linux (full log)

Partial log (click to expand)

machine: exit status 1
syncing
machine: running command: sync
machine: exit status 0
test script finished in 1420.05s
cleaning up
killing machine (pid 596)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/tmp/nix-build-vm-test-run-plasma5.drv-0/vde1.ctl': Directory not empty
/nix/store/kf3fbwjfsxfb5a3nwls7dpx9dlffrk0j-vm-test-run-plasma5

ttuegel · 2018-02-04T20:48:54Z

@grahamc
The test fails on aarch64 due to a problem with OCR; the root of the problem seems to be:

machine: waiting for (?^:Alice Foobar) to appear on the screen
machine: performing optical character recognition
machine: sending monitor command: screendump /build/ocrin.ppm
sh: command: not found

and later:

convert: unable to open image `/build/ocrin.ppm': No such file or directory @ error/blob.c/OpenBlob/2735.
convert: no images defined `tiff:-' @ error/convert.c/ConvertImageCommand/3258.

Is there a known issue with OCR on aarch64?

grahamc · 2018-02-04T21:00:52Z

cc @dezgeg

For now I'd not worry too much about the aarch64 failure.

ttuegel added 0.kind: bug 6.topic: qt/kde labels Feb 2, 2018

ttuegel self-assigned this Feb 2, 2018

GrahamcOfBorg added 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 labels Feb 2, 2018

ttuegel force-pushed the bugfix/plasma-integration/font-style branch from df57b96 to 89bc00d Compare February 3, 2018 17:48

ttuegel force-pushed the bugfix/plasma-integration/font-style branch from 89bc00d to a8176fc Compare February 4, 2018 14:32

GrahamcOfBorg added 6.topic: nixos 8.has: module (update) labels Feb 4, 2018

ttuegel added 2 commits February 4, 2018 13:31

plasma-integration: Upstream patch for Qt 5.8 font style names

d78f9f0

Since Qt 5.8, font style names are handled in a way that prevents alternate styles (bold, italic, etc.) from being selected for user interface fonts. See also: https://phabricator.kde.org/D9070

nixos/plasma5: Fix font style names in kdeglobals

77a607a

ttuegel force-pushed the bugfix/plasma-integration/font-style branch from a8176fc to 77a607a Compare February 4, 2018 19:31

ttuegel merged commit 4688dd0 into NixOS:master Feb 4, 2018

ttuegel deleted the bugfix/plasma-integration/font-style branch February 4, 2018 23:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

plasma-integration: Fix font style name bug with Qt >= 5.8 #34526

plasma-integration: Fix font style name bug with Qt >= 5.8 #34526

ttuegel commented Feb 2, 2018

ttuegel commented Feb 2, 2018

GrahamcOfBorg commented Feb 2, 2018

GrahamcOfBorg commented Feb 2, 2018

grahamc commented Feb 2, 2018

ttuegel commented Feb 2, 2018

pbogdan commented Feb 2, 2018 •

edited

grahamc commented Feb 3, 2018

GrahamcOfBorg commented Feb 3, 2018 •

edited by grahamc

GrahamcOfBorg commented Feb 3, 2018 •

edited by grahamc

grahamc commented Feb 3, 2018

ttuegel commented Feb 3, 2018

GrahamcOfBorg commented Feb 3, 2018

GrahamcOfBorg commented Feb 3, 2018

grahamc commented Feb 3, 2018

ttuegel commented Feb 3, 2018

ttuegel commented Feb 4, 2018

GrahamcOfBorg commented Feb 4, 2018

GrahamcOfBorg commented Feb 4, 2018

ttuegel commented Feb 4, 2018

GrahamcOfBorg commented Feb 4, 2018

GrahamcOfBorg commented Feb 4, 2018

ttuegel commented Feb 4, 2018

grahamc commented Feb 4, 2018

plasma-integration: Fix font style name bug with Qt >= 5.8 #34526

plasma-integration: Fix font style name bug with Qt >= 5.8 #34526

Conversation

ttuegel commented Feb 2, 2018

Motivation

Testing

ttuegel commented Feb 2, 2018

GrahamcOfBorg commented Feb 2, 2018

GrahamcOfBorg commented Feb 2, 2018

grahamc commented Feb 2, 2018

ttuegel commented Feb 2, 2018

pbogdan commented Feb 2, 2018 • edited

grahamc commented Feb 3, 2018

GrahamcOfBorg commented Feb 3, 2018 • edited by grahamc

GrahamcOfBorg commented Feb 3, 2018 • edited by grahamc

grahamc commented Feb 3, 2018

ttuegel commented Feb 3, 2018

GrahamcOfBorg commented Feb 3, 2018

GrahamcOfBorg commented Feb 3, 2018

grahamc commented Feb 3, 2018

ttuegel commented Feb 3, 2018

ttuegel commented Feb 4, 2018

GrahamcOfBorg commented Feb 4, 2018

GrahamcOfBorg commented Feb 4, 2018

ttuegel commented Feb 4, 2018

GrahamcOfBorg commented Feb 4, 2018

GrahamcOfBorg commented Feb 4, 2018

ttuegel commented Feb 4, 2018

grahamc commented Feb 4, 2018

pbogdan commented Feb 2, 2018 •

edited

GrahamcOfBorg commented Feb 3, 2018 •

edited by grahamc

GrahamcOfBorg commented Feb 3, 2018 •

edited by grahamc