Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.aiohttp: 2.3.9 -> 2.3.10 #34528

Merged
merged 2 commits into from Feb 3, 2018
Merged

pythonPackages.aiohttp: 2.3.9 -> 2.3.10 #34528

merged 2 commits into from Feb 3, 2018

Conversation

dotlambda
Copy link
Member

@dotlambda dotlambda commented Feb 2, 2018 •
edited

Motivation for this change

See aio-libs/aiohttp#2703 for why idna-ssl is only required for python<3.7.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@dotlambda dotlambda requested a review from FRidh as a code owner February 2, 2018 14:46
@dotlambda
Copy link
Member Author

dotlambda commented Feb 2, 2018 •
edited

@GrahamcOfBorg build aiohttp

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Partial log (click to expand)

error: attribute ‘aiohttp’ in selection path ‘aiohttp’ not found

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Partial log (click to expand)

error: attribute 'aiohttp' in selection path 'aiohttp' not found

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Partial log (click to expand)

error: attribute ‘aiohttp’ in selection path ‘aiohttp’ not found

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

tests/test_py35/test_client.py ........                                  [ 98%]
tests/test_py35/test_client_websocket_35.py .....                        [ 98%]
tests/test_py35/test_multipart_35.py ..                                  [ 98%]
tests/test_py35/test_resp.py .......                                     [ 99%]
tests/test_py35/test_streams_35.py .........                             [ 99%]
tests/test_py35/test_test_utils_35.py .........                          [ 99%]
tests/test_py35/test_web_websocket_35.py ..                              [100%]

============= 2008 passed, 25 skipped, 5 xfailed in 54.33 seconds ==============
/nix/store/ai2ss7manpwayprw2i6vz1fv2imb0cdc-python3.6-aiohttp-2.3.10

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Partial log (click to expand)

error: attribute 'aiohttp' in selection path 'aiohttp' not found

@dotlambda
Copy link
Member Author

@GrahamcOfBorg build python3.pkgs.aiohttp

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

/nix/store/ai2ss7manpwayprw2i6vz1fv2imb0cdc-python3.6-aiohttp-2.3.10

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

tests/test_py35/test_client.py ........                                  [ 98%]
tests/test_py35/test_client_websocket_35.py .....                        [ 98%]
tests/test_py35/test_multipart_35.py ..                                  [ 98%]
tests/test_py35/test_resp.py .......                                     [ 99%]
tests/test_py35/test_streams_35.py .........                             [ 99%]
tests/test_py35/test_test_utils_35.py .........                          [ 99%]
tests/test_py35/test_web_websocket_35.py ..                              [100%]

============= 2008 passed, 25 skipped, 5 xfailed in 187.89 seconds =============
/nix/store/7hc4drnb0r90k78164bnw8r902q7xay7-python3.6-aiohttp-2.3.10

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

these derivations will be built:
  /nix/store/fi18w146dzsvj3anxpm8wklxwn6h4j49-python3.6-aiohttp-2.3.10.drv
waiting for locks or build slots...
/nix/store/7hc4drnb0r90k78164bnw8r902q7xay7-python3.6-aiohttp-2.3.10

@FRidh FRidh merged commit c2b84b2 into NixOS:master Feb 3, 2018
@dotlambda dotlambda deleted the aiohttp branch February 3, 2018 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dotlambda @GrahamcOfBorg @FRidh