Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.pytest-aiohttp: disable tests #34529

Merged
merged 1 commit into from Feb 3, 2018
Merged

pythonPackages.pytest-aiohttp: disable tests #34529

merged 1 commit into from Feb 3, 2018

Conversation

dotlambda
Copy link
Member

Motivation for this change

Spotted a "Ran 0 tests".

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@dotlambda dotlambda requested a review from FRidh as a code owner February 2, 2018 14:49
@jtojnar
Copy link
Contributor

jtojnar commented Feb 2, 2018

Why does it matter that tests are enabled if there are no tests?

@dotlambda
Copy link
Member Author

@FRidh is quite picky about that. I don't know why :)

@FRidh
Copy link
Member

FRidh commented Feb 3, 2018

Ran 0 tests is undesirable because it can mean that

  • tests are not available
  • tests could not be found due to an incorrect test runner setup

If we know that tests are not available, then we can use the Ran 0 tests as an indicator for an incorrect test runner setup. Considering there are various ways test runners are invoked this is useful.

One could then argue that, if in a later update tests were added, they would not be run. And that's correct; having doCheck = false; along with a comment should push the contributor/reviewer to verify whether after an update it is possible to re-enable testing.

@FRidh FRidh merged commit 360e019 into NixOS:master Feb 3, 2018
@dotlambda dotlambda deleted the pytest-aiohttp branch February 3, 2018 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dotlambda @jtojnar @FRidh @GrahamcOfBorg