New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
infamousPlugins: init at 0.2.03 #34522
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Builds fine, but I have no idea what this can be used for, would be nice to have some more info on that.
}; | ||
|
||
nativeBuildInputs = [ pkgconfig ]; | ||
buildInputs = [ cairomm cmake lv2 libpthreadstubs libXdmcp libXft ntk pcre fftwFloat zita-resampler ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't cmake be in nativeBuildInputs too?
pkgs/top-level/all-packages.nix
Outdated
@@ -2846,6 +2846,8 @@ with pkgs; | |||
|
|||
inform7 = callPackage ../development/compilers/inform7 { }; | |||
|
|||
infamousPlugins = callPackage ../applications/audio/infamousPlugins { }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indentation off
buildInputs = [ cairomm cmake lv2 libpthreadstubs libXdmcp libXft ntk pcre fftwFloat zita-resampler ]; | ||
|
||
meta = with stdenv.lib; { | ||
homepage = http://ssj71.github.io/infamousPlugins; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/http/https
1bdf59c
to
2e8d620
Compare
@infinisil Thanks for the feedback, all done. |
Motivation for this change
Things done
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)