nixos/physlock: add allowAnyUser option #34524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
infinisil
changed the title
|
(Why can't we get the mention bot back? `git blame` has all the info.)
I feel that this change is incorrect.
1) I feel really insecure about introducing new setuid binaries then you can do the same without them.
2) Users could have added dependencies to `physlock.service` (like dropping LUKS keys), this change would ignore all of that.
The proper way to do this is to allow `systemctl start physlock` to all users (no idea how to do this with systemd).
I archive the same effect by simply defining a button:
```nix
services.actkbd.bindings = [
# "screensaver" and "ms extended 1" keys lock the screen
{ keys = [ 152 184 ]; attributes = [ "any" "exec" ]; events = [ "key" ]; command = "systemctl start physlock"; }
];
```
|
|
@oxij If you're still interested in this, the polkit rule allows every user to run |
|
That's good to know, thanks.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
physlock required root permissions to run. This PR adds the allowAnyUser option, which adds a setuid wrapper for physlock, allowing any user to lock the screen by calling the binary
physlock.Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)