Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnome3.gexiv2: re-enable bindings #34525

Merged
merged 1 commit into from Feb 2, 2018
Merged

gnome3.gexiv2: re-enable bindings #34525

merged 1 commit into from Feb 2, 2018

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Feb 2, 2018 •
edited

Motivation for this change

After effa9e4, which switched to Meson, the Vala bindings were not built which broke Shotwell. Enabling Vala was not enough due to a bug, though, so we have to patch it.

cc @mdorman

Closes: #34512

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@jtojnar jtojnar added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Feb 2, 2018
@jtojnar
Copy link
Contributor Author

jtojnar commented Feb 2, 2018

@GrahamcOfBorg build shotwell

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘shotwell-0.27.2’ in /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/applications/graphics/shotwell/default.nix:36 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

shrinking /nix/store/4z1z3mxzzvc8sasd523bp7rp7xxd1aqa-shotwell-0.27.2/lib/shotwell/plugins/builtin/libshotwell-publishing-extras.so
shrinking /nix/store/4z1z3mxzzvc8sasd523bp7rp7xxd1aqa-shotwell-0.27.2/lib/shotwell/plugins/builtin/libshotwell-transitions.so
shrinking /nix/store/4z1z3mxzzvc8sasd523bp7rp7xxd1aqa-shotwell-0.27.2/lib/shotwell/plugins/builtin/libshotwell-publishing.so
shrinking /nix/store/4z1z3mxzzvc8sasd523bp7rp7xxd1aqa-shotwell-0.27.2/lib/libshotwell-plugin-common.so.0.27.2
gzipping man pages under /nix/store/4z1z3mxzzvc8sasd523bp7rp7xxd1aqa-shotwell-0.27.2/share/man/
strip is /nix/store/mdyy001q67hiks0g24ra53z7ckm4jfr4-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/4z1z3mxzzvc8sasd523bp7rp7xxd1aqa-shotwell-0.27.2/lib  /nix/store/4z1z3mxzzvc8sasd523bp7rp7xxd1aqa-shotwell-0.27.2/libexec  /nix/store/4z1z3mxzzvc8sasd523bp7rp7xxd1aqa-shotwell-0.27.2/bin 
patching script interpreter paths in /nix/store/4z1z3mxzzvc8sasd523bp7rp7xxd1aqa-shotwell-0.27.2
/nix/store/4z1z3mxzzvc8sasd523bp7rp7xxd1aqa-shotwell-0.27.2/libexec/shotwell/.shotwell-settings-migrator-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/i0ay05pqkbnvpfijm52mmlrp6kmkl80c-bash-4.4-p12/bin/sh"
checking for references to /tmp/nix-build-shotwell-0.27.2.drv-0 in /nix/store/4z1z3mxzzvc8sasd523bp7rp7xxd1aqa-shotwell-0.27.2...

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

shrinking /nix/store/qfpz88p3kbllc84dgh5mx5l1hmg91npl-shotwell-0.27.2/lib/libshotwell-authenticator.so.0.27.2
shrinking /nix/store/qfpz88p3kbllc84dgh5mx5l1hmg91npl-shotwell-0.27.2/lib/libshotwell-plugin-common.so.0.27.2
shrinking /nix/store/qfpz88p3kbllc84dgh5mx5l1hmg91npl-shotwell-0.27.2/bin/.shotwell-wrapped
gzipping man pages under /nix/store/qfpz88p3kbllc84dgh5mx5l1hmg91npl-shotwell-0.27.2/share/man/
strip is /nix/store/jwz859pxqj7sl2dbwvmxkx68jp774izb-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/qfpz88p3kbllc84dgh5mx5l1hmg91npl-shotwell-0.27.2/lib  /nix/store/qfpz88p3kbllc84dgh5mx5l1hmg91npl-shotwell-0.27.2/libexec  /nix/store/qfpz88p3kbllc84dgh5mx5l1hmg91npl-shotwell-0.27.2/bin
patching script interpreter paths in /nix/store/qfpz88p3kbllc84dgh5mx5l1hmg91npl-shotwell-0.27.2
/nix/store/qfpz88p3kbllc84dgh5mx5l1hmg91npl-shotwell-0.27.2/libexec/shotwell/.shotwell-settings-migrator-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/rc78viijga8i0m4imrnqk8d1csyqr8yx-bash-4.4-p12/bin/sh"
checking for references to /build in /nix/store/qfpz88p3kbllc84dgh5mx5l1hmg91npl-shotwell-0.27.2...
/nix/store/qfpz88p3kbllc84dgh5mx5l1hmg91npl-shotwell-0.27.2

@jtojnar
gnome3.gexiv2: re-enable bindings
f8c59e0 
After effa9e4, which switched to Meson,
the Vala bindings were not built which broke Shotwell. Enabling Vala
was not enough due to a bug, though, so we have to patch it.
@jtojnar jtojnar merged commit f8c59e0 into NixOS:master Feb 2, 2018
@jtojnar jtojnar deleted the gexiv-gir branch February 2, 2018 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jtojnar @GrahamcOfBorg