Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

muscle: init at 3.8.31 #34334

Merged
merged 2 commits into from Jan 28, 2018
Merged

muscle: init at 3.8.31 #34334

merged 2 commits into from Jan 28, 2018

Conversation

unode
Copy link
Member

@unode unode commented Jan 27, 2018

Motivation for this change

Introduces MUSCLE, a commonly used bioinformatics tool for multiple sequence alignments.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@srhb
Copy link
Contributor

srhb commented Jan 28, 2018

@GrahamcOfBorg build muscle

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: x86_64-linux

configuring
no configure script, doing nothing
building
build flags: SHELL=/nix/store/i0ay05pqkbnvpfijm52mmlrp6kmkl80c-bash-4.4-p12/bin/bash
chmod +x ./mk
./mk
/nix/store/i0ay05pqkbnvpfijm52mmlrp6kmkl80c-bash-4.4-p12/bin/bash: ./mk: /bin/bash: bad interpreter: No such file or directory
make: *** [Makefile:3: muscle] Error 126
builder for ‘/nix/store/wq8ir3v8dsxb8dp278ncdi3pwc8kiq7h-muscle-3.8.31.drv’ failed with exit code 2
error: build of ‘/nix/store/wq8ir3v8dsxb8dp278ncdi3pwc8kiq7h-muscle-3.8.31.drv’ failed

Full log: https://logs.nix.gsc.io/?key=nixos/nixpkgs.34334

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: aarch64-linux

configuring
no configure script, doing nothing
building
build flags: SHELL=/nix/store/rc78viijga8i0m4imrnqk8d1csyqr8yx-bash-4.4-p12/bin/bash
chmod +x ./mk
./mk
/nix/store/rc78viijga8i0m4imrnqk8d1csyqr8yx-bash-4.4-p12/bin/bash: ./mk: /bin/bash: bad interpreter: No such file or directory
make: *** [Makefile:3: muscle] Error 126
builder for '/nix/store/aaj954spib19bc2swpjr2ff7bx92i0bh-muscle-3.8.31.drv' failed with exit code 2
error: build of '/nix/store/aaj954spib19bc2swpjr2ff7bx92i0bh-muscle-3.8.31.drv' failed

Full log: https://logs.nix.gsc.io/?key=nixos/nixpkgs.34334

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: x86_64-darwin

./mk: line 9: g++: command not found
./mk: line 9: g++: command not found
./mk: line 9: g++: command not found
./mk: line 16: g++: command not found
error: strip: can't open file: muscle (No such file or directory)
ls: cannot access 'muscle': No such file or directory
sum: muscle: No such file or directory
make: *** [Makefile:3: muscle] Error 1
builder for '/nix/store/mg4z3f618kza3f79rh3marx4rzmb75rg-muscle-3.8.31.drv' failed with exit code 2
error: build of '/nix/store/mg4z3f618kza3f79rh3marx4rzmb75rg-muscle-3.8.31.drv' failed

Full log: https://logs.nix.gsc.io/?key=nixos/nixpkgs.34334

@srhb
Copy link
Contributor

srhb commented Jan 28, 2018

Looks like there's some shebangs that need patching. There's no /bin/bash which mk refers to. :)

@unode
Copy link
Member Author

unode commented Jan 28, 2018

Patched and built with sandbox. Not tested on NixOS yet.

@unode
Copy link
Member Author

unode commented Jan 28, 2018

Also not entirely sure how to handle darwin. No experience with that.
Unless patching the shell also addresses the problems there.

@unode
Copy link
Member Author

unode commented Jan 28, 2018

@GrahamcOfBorg build muscle

1 similar comment
@srhb
Copy link
Contributor

srhb commented Jan 28, 2018

@GrahamcOfBorg build muscle

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: x86_64-darwin

./mk: line 9: g++: command not found
./mk: line 9: g++: command not found
./mk: line 9: g++: command not found
./mk: line 16: g++: command not found
error: strip: can't open file: muscle (No such file or directory)
ls: cannot access 'muscle': No such file or directory
sum: muscle: No such file or directory
make: *** [Makefile:3: muscle] Error 1
builder for '/nix/store/3khv5ypx9h463vv7yx0wxadjk4rh70zk-muscle-3.8.31.drv' failed with exit code 2
error: build of '/nix/store/3khv5ypx9h463vv7yx0wxadjk4rh70zk-muscle-3.8.31.drv' failed

Full log: https://logs.nix.gsc.io/?key=nixos/nixpkgs.34334

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: aarch64-linux

g++: error: usage.o: No such file or directory
g++: error: validateids.o: No such file or directory
g++: error: vtml2.o: No such file or directory
g++: error: writescorefile.o: No such file or directory
strip: 'muscle': No such file
ls: cannot access 'muscle': No such file or directory
sum: muscle: No such file or directory
make: *** [Makefile:3: muscle] Error 1
builder for '/nix/store/4vbx5aabvr1bpk159hjvcq5l26jcxsm3-muscle-3.8.31.drv' failed with exit code 2
error: build of '/nix/store/4vbx5aabvr1bpk159hjvcq5l26jcxsm3-muscle-3.8.31.drv' failed

Full log: https://logs.nix.gsc.io/?key=nixos/nixpkgs.34334

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-linux

install: creating directory '/nix/store/7vzw4ccqn1rmqf802mq28k2zfv1sf47d-muscle-3.8.31/bin'
'muscle' -> '/nix/store/7vzw4ccqn1rmqf802mq28k2zfv1sf47d-muscle-3.8.31/bin/muscle'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/7vzw4ccqn1rmqf802mq28k2zfv1sf47d-muscle-3.8.31
shrinking /nix/store/7vzw4ccqn1rmqf802mq28k2zfv1sf47d-muscle-3.8.31/bin/muscle
strip is /nix/store/mdyy001q67hiks0g24ra53z7ckm4jfr4-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/7vzw4ccqn1rmqf802mq28k2zfv1sf47d-muscle-3.8.31/bin 
patching script interpreter paths in /nix/store/7vzw4ccqn1rmqf802mq28k2zfv1sf47d-muscle-3.8.31
checking for references to /tmp/nix-build-muscle-3.8.31.drv-0 in /nix/store/7vzw4ccqn1rmqf802mq28k2zfv1sf47d-muscle-3.8.31...
/nix/store/7vzw4ccqn1rmqf802mq28k2zfv1sf47d-muscle-3.8.31

Full log: https://logs.nix.gsc.io/?key=nixos/nixpkgs.34334

@srhb
Copy link
Contributor

srhb commented Jan 28, 2018

I guess a meta.platforms = stdenv.lib.platforms.linux; might be helpful here.

@srhb
Copy link
Contributor

srhb commented Jan 28, 2018

By the way, you can request access to ofborg here: NixOS/ofborg#22

@unode
Copy link
Member Author

unode commented Jan 28, 2018

This package is supposed to be compatible with MacOS both Intel and PPC but I guess this needs further testing.
Progressing with Linux for now.

@srhb
Copy link
Contributor

srhb commented Jan 28, 2018

Looks good to me. Ready for merge?

@unode
Copy link
Member Author

unode commented Jan 28, 2018

Just waiting on checks. Other than that 👍

@srhb
Copy link
Contributor

srhb commented Jan 28, 2018

Thanks!

@srhb srhb merged commit db00d2e into NixOS:master Jan 28, 2018
@LnL7
Copy link
Member

LnL7 commented Jan 28, 2018

Using cc/c++ works both for gcc and clang.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants