pythonPackages.hbmqtt: init at 0.9.1 #34322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andir
requested changes
Jan 27, 2018
| }; | ||
|
|
||
| postPatch = '' | ||
| substituteInPlace setup.py --replace "dill<0.2.7" dill |
There was a problem hiding this comment.
Would you mind pinging upstream about this?
This seems to have been introduced with pytransitions/transitions@19ec2ab and since then forgotten?
Are we not seeing the same issues for some reason?
There was a problem hiding this comment.
No, I'm not seeing any errors. I've opened an upstream issue.
There was a problem hiding this comment.
This is no longer a problem according to pytransitions/transitions#286 (comment).
| { stdenv, buildPythonPackage, fetchPypi | ||
| , transitions, websockets, passlib, docopt, pyyaml, nose }: | ||
|
|
||
| buildPythonPackage rec { |
There was a problem hiding this comment.
Shouldn't you have a disabled = !isPy3k since as you mentioned this only works on python3+?
There was a problem hiding this comment.
Yes, but websockets is py3 only as well, so it's automatic. I'll add it anyway.
|
@GrahamcOfBorg build python3Packages.transitions python3Packages.hbmqtt |
There was a problem hiding this comment.
Success for system: x86_64-linux
File "/nix/store/53dyjh7xjhnbibqllr7j27lk2h98n7j7-python3-3.6.4/lib/python3.6/asyncio/base_events.py", line 574, in call_soon
File "/nix/store/53dyjh7xjhnbibqllr7j27lk2h98n7j7-python3-3.6.4/lib/python3.6/asyncio/base_events.py", line 357, in _check_closed
RuntimeError: Event loop is closed
Exception ignored in: <generator object BrokerProtocolHandler.get_next_pending_unsubscription at 0x7ffff0637e60>
Traceback (most recent call last):
File "/tmp/nix-build-python3.6-hbmqtt-0.9.1.drv-0/hbmqtt-0.9.1/hbmqtt/mqtt/protocol/broker_handler.py", line 96, in get_next_pending_unsubscription
File "/nix/store/53dyjh7xjhnbibqllr7j27lk2h98n7j7-python3-3.6.4/lib/python3.6/asyncio/queues.py", line 169, in get
File "/nix/store/53dyjh7xjhnbibqllr7j27lk2h98n7j7-python3-3.6.4/lib/python3.6/asyncio/base_events.py", line 574, in call_soon
File "/nix/store/53dyjh7xjhnbibqllr7j27lk2h98n7j7-python3-3.6.4/lib/python3.6/asyncio/base_events.py", line 357, in _check_closed
RuntimeError: Event loop is closed
There was a problem hiding this comment.
Success for system: aarch64-linux
File "/nix/store/mn2c28fa7mp8ck3p74n80nls6g2w7flw-python3-3.6.4/lib/python3.6/asyncio/base_events.py", line 574, in call_soon
File "/nix/store/mn2c28fa7mp8ck3p74n80nls6g2w7flw-python3-3.6.4/lib/python3.6/asyncio/base_events.py", line 357, in _check_closed
RuntimeError: Event loop is closed
Exception ignored in: <generator object BrokerProtocolHandler.get_next_pending_unsubscription at 0xffffb4832410>
Traceback (most recent call last):
File "/build/hbmqtt-0.9.1/hbmqtt/mqtt/protocol/broker_handler.py", line 96, in get_next_pending_unsubscription
File "/nix/store/mn2c28fa7mp8ck3p74n80nls6g2w7flw-python3-3.6.4/lib/python3.6/asyncio/queues.py", line 169, in get
File "/nix/store/mn2c28fa7mp8ck3p74n80nls6g2w7flw-python3-3.6.4/lib/python3.6/asyncio/base_events.py", line 574, in call_soon
File "/nix/store/mn2c28fa7mp8ck3p74n80nls6g2w7flw-python3-3.6.4/lib/python3.6/asyncio/base_events.py", line 357, in _check_closed
RuntimeError: Event loop is closed
|
@GrahamcOfBorg build python3Packages.transitions python3Packages.hbmqtt python2Packages.transitions |
There was a problem hiding this comment.
Success on x86_64-linux (full log)
Partial log (click to expand)
checking for references to /tmp/nix-build-python2.7-transitions-0.6.4.drv-0 in /nix/store/9lpzz2m8bp6irlkwg4r4j0753wsrngwm-python2.7-transitions-0.6.4...
running install tests
.....................................S.............SSSSSSSSSSSSSSSSSSSSSSSSSSSS..................................................S..............................................S...........SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS.......SSSSSSSSSSSSSS.....................................................S...................................................S...............................................S............................................S......................................................S.............
----------------------------------------------------------------------
Ran 534 tests in 17.121s
OK (SKIP=108)
/nix/store/9h23y2sfgcb02f8h8qgbcsh1jy9782rl-python3.6-transitions-0.6.4
/nix/store/vqr3rfwz9lvvik94n57w5c9np2y3g98j-python3.6-hbmqtt-0.9.1
/nix/store/9lpzz2m8bp6irlkwg4r4j0753wsrngwm-python2.7-transitions-0.6.4
There was a problem hiding this comment.
Success on x86_64-darwin (full log)
Partial log (click to expand)
File "/nix/store/wc4m3g4grivhy26sdck44jxwkvz1j17n-python3-3.6.4/lib/python3.6/asyncio/base_events.py", line 574, in call_soon
File "/nix/store/wc4m3g4grivhy26sdck44jxwkvz1j17n-python3-3.6.4/lib/python3.6/asyncio/base_events.py", line 357, in _check_closed
RuntimeError: Event loop is closed
Exception ignored in: <generator object BrokerProtocolHandler.get_next_pending_unsubscription at 0x10ff3c888>
Traceback (most recent call last):
File "/private/tmp/nix-build-python3.6-hbmqtt-0.9.1.drv-0/hbmqtt-0.9.1/hbmqtt/mqtt/protocol/broker_handler.py", line 96, in get_next_pending_unsubscription
File "/nix/store/wc4m3g4grivhy26sdck44jxwkvz1j17n-python3-3.6.4/lib/python3.6/asyncio/queues.py", line 169, in get
File "/nix/store/wc4m3g4grivhy26sdck44jxwkvz1j17n-python3-3.6.4/lib/python3.6/asyncio/base_events.py", line 574, in call_soon
File "/nix/store/wc4m3g4grivhy26sdck44jxwkvz1j17n-python3-3.6.4/lib/python3.6/asyncio/base_events.py", line 357, in _check_closed
RuntimeError: Event loop is closed
There was a problem hiding this comment.
Success on aarch64-linux (full log)
Partial log (click to expand)
File "/nix/store/mn2c28fa7mp8ck3p74n80nls6g2w7flw-python3-3.6.4/lib/python3.6/asyncio/base_events.py", line 574, in call_soon
File "/nix/store/mn2c28fa7mp8ck3p74n80nls6g2w7flw-python3-3.6.4/lib/python3.6/asyncio/base_events.py", line 357, in _check_closed
RuntimeError: Event loop is closed
Exception ignored in: <generator object BrokerProtocolHandler.get_next_pending_unsubscription at 0xffffb483a410>
Traceback (most recent call last):
File "/build/hbmqtt-0.9.1/hbmqtt/mqtt/protocol/broker_handler.py", line 96, in get_next_pending_unsubscription
File "/nix/store/mn2c28fa7mp8ck3p74n80nls6g2w7flw-python3-3.6.4/lib/python3.6/asyncio/queues.py", line 169, in get
File "/nix/store/mn2c28fa7mp8ck3p74n80nls6g2w7flw-python3-3.6.4/lib/python3.6/asyncio/base_events.py", line 574, in call_soon
File "/nix/store/mn2c28fa7mp8ck3p74n80nls6g2w7flw-python3-3.6.4/lib/python3.6/asyncio/base_events.py", line 357, in _check_closed
RuntimeError: Event loop is closed
andir
approved these changes
Jan 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hbmqtt is Python 3 only, while transitions works with Python 2 as well.
The disabled tests require network access in the case of hbmqtt and optional dependencies in the case of transitions.
Running the hbmqtt tests yields some ignored excptions, which seems to be perfectly normal: https://travis-ci.org/beerfactory/hbmqtt/jobs/307132698
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)