Don't use heredoc inside interpolation #5648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RX14
approved these changes
Jan 27, 2018
makenowjust
force-pushed
the
fix/crystal/dont-use-heredoc-inside-interpolation
branch
from
fd21faf
to
697043e
Compare
|
ping @asterite. Could you review this? |
|
@makenowjust no, sorry, I won't have time to review PRs related to the compiler. I'll just discuss issues and approve trivial PRs |
straight-shoota
approved these changes
Mar 12, 2018
RX14
approved these changes
Mar 12, 2018
|
Maybe rebase? to make sure it still works who knows... |
makenowjust
force-pushed
the
fix/crystal/dont-use-heredoc-inside-interpolation
branch
from
697043e
to
adacab6
Compare
heredoc inside interpolation is buggy and it is unuseful. It is a bit hard to fix this, so I'd like to forbid.
makenowjust
force-pushed
the
fix/crystal/dont-use-heredoc-inside-interpolation
branch
from
adacab6
to
b1dd55e
Compare
|
@RX14 I think this failed is irrelevant. Could you re-run CircleCI job? |
|
Thank you. |
|
@makenowjust just to clarify, is this a breaking change or not? (i.e. did this work before or is this just improving the error message) |
|
@RX14 Just a bug fix (or bug hiding). There is no source code broken by this. |
makenowjust
deleted the
fix/crystal/dont-use-heredoc-inside-interpolation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A heredoc inside interpolation is buggy. For example, this code cannot be compiled even though it was valid Ruby code:
And this code is compiled even though it was invalid Ruby code:
I tried to fix these, however I did't complete it and I found it is a bit hard to fix.
A heredoc inside interpolation is very tricky, so I suggest forbidding this.
Thank you.