Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: Platform attribute cleanup #34315

Merged
merged 2 commits into from
Jan 27, 2018
Merged

lib: Platform attribute cleanup #34315

merged 2 commits into from
Jan 27, 2018
+22 −42

Conversation

Ericson2314
Copy link
Member

@Ericson2314 Ericson2314 commented Jan 27, 2018 •
edited
Loading

Motivation for this change

Progress towards #34274

Things done

No native hashes should be changed. Only cross openssl's hash should be changed.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@Ericson2314
lib: Remove examples platforms' bigEndian attr
46d501a 
They still have `parsed.cpu.significantByte` which has the same info.
@Ericson2314
lib, openssl: Get rid of openssl.system
668e752 
We compute it on the fly, careful to avoid any mass rebuilds for now.
@Ericson2314 Ericson2314 requested a review from dezgeg January 27, 2018 01:56
@Ericson2314 Ericson2314 requested a review from nbp as a code owner January 27, 2018 01:56
@Ericson2314
Copy link
Member Author

Ericson2314 commented Jan 27, 2018 •
edited
Loading

@teto the openssl changes here are a is good example of the sort of change that should be done for the Linux kernel.

@Ericson2314 Ericson2314 mentioned this pull request Jan 27, 2018
Open
6 tasks
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 27, 2018
@Ericson2314 Ericson2314 merged commit 57b01b1 into NixOS:master Jan 27, 2018
@Ericson2314 Ericson2314 deleted the lib-system-cleanup branch January 27, 2018 02:22
@dtzWill
Copy link
Member

dtzWill commented Jan 28, 2018

I know already merged, but LGTM and tested to work well in my tree as well!

Thanks for these cleanups!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dezgeg dezgeg

@nbp nbp

Assignees

@dezgeg dezgeg

Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Ericson2314 @dtzWill @dezgeg @GrahamcOfBorg