Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node-packages.json-diff: init at 0.5.2 #34327

Merged
merged 1 commit into from Feb 10, 2018
Merged

node-packages.json-diff: init at 0.5.2 #34327

merged 1 commit into from Feb 10, 2018

Conversation

mnacamura
Copy link
Contributor

Motivation for this change

From the github page:
JSON diff

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

infinisil
infinisil approved these changes Feb 2, 2018
View reviewed changes
Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built and tested this, works without problems

@Mic92 Mic92 merged commit 7e1ebc2 into NixOS:master Feb 10, 2018
@Mic92
Copy link
Member

Mic92 commented Feb 10, 2018

Thanks!

@mnacamura mnacamura deleted the node-json-diff branch February 10, 2018 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil infinisil approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mnacamura @Mic92 @infinisil @GrahamcOfBorg